From: Tiwei Bie <tiwei.bie@intel.com>
To: "Yu, Jin" <jin.yu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Liu, Changpeng" <changpeng.liu@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 10/10] vhost: add vhost-user-blk example which support inflight
Date: Thu, 26 Sep 2019 22:40:29 +0800 [thread overview]
Message-ID: <20190926144029.GA23868@___> (raw)
In-Reply-To: <B9FBC361811A3D4DBB02350807E29F7B0B95B638@SHSMSX101.ccr.corp.intel.com>
On Thu, Sep 26, 2019 at 10:29:19PM +0800, Yu, Jin wrote:
> > -----Original Message-----
> > From: Bie, Tiwei
> > Sent: Wednesday, September 25, 2019 10:46 PM
> > To: Yu, Jin <jin.yu@intel.com>
> > Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>;
> > maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>
> > Subject: Re: [PATCH v7 10/10] vhost: add vhost-user-blk example which support
> > inflight
> >
> > On Fri, Sep 20, 2019 at 08:01:02PM +0800, Jin Yu wrote:
> > > A vhost-user-blk example that support inflight feature. It uses the
> > > new APIs that introduced in the first patch, so It can show how there
> >
> > s/It/it/
> > s/there/these/
>
> Got it. Thanks.
> >
> > > APIs work to support inflight feature.
> > >
> > > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > > ---
> > > V1 - add the case.
> > > V2 - add the rte_vhost prefix.
> > > V3 - add packed ring support
> > > ---
> > > examples/vhost_blk/Makefile | 67 ++
> > > examples/vhost_blk/blk.c | 125 +++
> > > examples/vhost_blk/blk_spec.h | 95 ++
> > > examples/vhost_blk/meson.build | 20 +
> > > examples/vhost_blk/vhost_blk.c | 1313 +++++++++++++++++++++++++
> > > examples/vhost_blk/vhost_blk.h | 116 +++
> > > examples/vhost_blk/vhost_blk_compat.c | 195 ++++
> > > 7 files changed, 1931 insertions(+)
> >
> > I met some build issues when trying this example.
> >
> > examples/vhost_blk/vhost_blk.c: In function ‘descriptor_get_next_packed’:
> > examples/vhost_blk/vhost_blk.c:71:21: error: invalid use of undefined type
> > ‘struct vring_packed_desc’
> > if (vq->desc_packed[*idx % vq->size].flags & VIRTQ_DESC_F_NEXT) {
> > ^
> > examples/vhost_blk/vhost_blk.c:71:21: error: dereferencing pointer to
> > incomplete type ‘struct vring_packed_desc’
> > examples/vhost_blk/vhost_blk.c:73:26: error: invalid use of undefined type
> > ‘struct vring_packed_desc’
> > return &vq->desc_packed[*idx % vq->size];
>
> The new version of virtio_ring.h have defined the vring_packed_desc.
> For the compatibility， I will add the definition in the rte_vhost.h.
No. They should be added in this example instead of
the vhost API.
> Thanks.
>
> > ^
> > examples/vhost_blk/vhost_blk.c: In function
> > ‘inflight_submit_completion_packed’:
> > examples/vhost_blk/vhost_blk.c:165:2: warning:
> > ‘rte_vhost_set_last_inflight_io_packed’ is deprecated: Symbol is not yet part of
> > stable ABI [-Wdeprecated-declarations]
>
> Should I ignore this warning？ I'm not sure about this.
> The reason is the _rte_experiment keyword?
You need something like this:
https://github.com/DPDK/dpdk/blob/bd253daa7717835f88bbc58b09a94d0060380396/examples/vhost/Makefile#L29
https://github.com/DPDK/dpdk/blob/bd253daa7717835f88bbc58b09a94d0060380396/examples/vhost/meson.build#L13
> Thanks.
> > ret = rte_vhost_set_last_inflight_io_packed(ctrlr->bdev->vid, q_idx,
> > ^~~
> > In file included from examples/vhost_blk/vhost_blk.c:17:0:
> > x86_64-native-linuxapp-gcc/include/rte_vhost.h:810:1: note: declared here
> > rte_vhost_set_last_inflight_io_packed(int vid,
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ^
> > ...
next prev parent reply other threads:[~2019-09-26 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190917145234.16951>
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 00/10] vhost: support inflight share memory protocol feature Jin Yu
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 01/10] vhost: add the inflight description Jin Yu
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 02/10] vhost: add packed ring Jin Yu
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 03/10] vhost: add the inflight structure Jin Yu
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 04/10] vhost: add two new messages to support a shared buffer Jin Yu
2019-09-26 7:39 ` Tiwei Bie
2019-09-26 15:06 ` Yu, Jin
2019-09-27 2:12 ` Tiwei Bie
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 05/10] vhost: checkout the resubmit inflight information Jin Yu
2019-09-26 8:04 ` Tiwei Bie
2019-09-26 15:52 ` Yu, Jin
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 06/10] vhost: add the APIs to operate inflight ring Jin Yu
2019-09-20 12:00 ` [dpdk-dev] [PATCH v7 07/10] vhost: add APIs for user getting " Jin Yu
2019-09-20 12:01 ` [dpdk-dev] [PATCH v7 08/10] vhost: add vring functions packed ring support Jin Yu
2019-09-20 12:01 ` [dpdk-dev] [PATCH v7 09/10] vhost: add an API for judging vq format Jin Yu
2019-09-20 12:01 ` [dpdk-dev] [PATCH v7 10/10] vhost: add vhost-user-blk example which support inflight Jin Yu
2019-09-25 14:45 ` Tiwei Bie
2019-09-26 14:29 ` Yu, Jin
2019-09-26 14:40 ` Tiwei Bie [this message]
2019-09-25 14:25 ` [dpdk-dev] [PATCH v7 00/10] vhost: support inflight share memory protocol feature Tiwei Bie
2019-09-26 14:00 ` Yu, Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926144029.GA23868@___ \
--to=tiwei.bie@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).