From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Simei Su <simei.su@intel.com>, qi.z.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 3/3] net/ice: enable advanced RSS
Date: Tue, 22 Oct 2019 10:04:18 +0800 [thread overview]
Message-ID: <20191022020418.GA23673@intel.com> (raw)
In-Reply-To: <1ae6154d-4524-1716-8ee7-7f88d55a2175@intel.com>
Off the list
Hi, Ferruh
On 10/21, Ferruh Yigit wrote:
>On 10/21/2019 1:06 PM, Simei Su wrote:
>> This patch supports:
>> (1)symmetric hash by rte_flow RSS action.
>> (2)input set change by rte_flow RSS action.
>>
>> Signed-off-by: Simei Su <simei.su@intel.com>
>> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
><...>
>
>> +static int
>> +ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
>> + const struct rte_flow_action actions[],
>> + void **meta,
>> + struct rte_flow_error *error)
>> +{
>> + const struct rte_flow_action *action;
>> + enum rte_flow_action_type action_type;
>> + const struct rte_flow_action_rss *rss;
>> + struct rss_type_match_hdr *m = (struct rss_type_match_hdr *)
>> + (pattern_match_item->meta);
>> + uint32_t type_list_len = RTE_DIM(ice_hash_type_list);
>> + struct ice_hash_match_type *type_match_item;
>> +
>> + /* Supported action is RSS. */
>> + for (action = actions; action->type !=
>> + RTE_FLOW_ACTION_TYPE_END; action++) {
>> + action_type = action->type;
>> + switch (action_type) {
>> + case RTE_FLOW_ACTION_TYPE_RSS:
>> + rss = action->conf;
>> + uint16_t i;
>> + uint64_t rss_hf = rss->types;
>
>ICC is giving following error [1], it seems switch case is not a scope, so
>fixing the warning while merging by moving the definitions above switch.
>
>
>[1]
>error #589: transfer of control bypasses initialization of:
> variable "rss_hf" (declared at line 299)
> switch (action_type) {
> ^
>
Thanks for fixing this, just wonder why build report on patchwork didn't catch
this issue?
http://mails.dpdk.org/archives/test-report/2019-October/103686.html
Thanks,
Xiaolong
next prev parent reply other threads:[~2019-10-22 2:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1567866291-268287-1-git-send-email-simei.su@intel.com>
2019-09-09 14:56 ` [dpdk-dev] [PATCH v2] " Simei Su
2019-09-12 16:19 ` Ye Xiaolong
2019-09-16 1:47 ` Su, Simei
2019-09-19 5:15 ` [dpdk-dev] [PATCH v3] " Simei Su
2019-09-27 9:53 ` [dpdk-dev] [PATCH v4 0/2] " Simei Su
2019-09-27 9:53 ` [dpdk-dev] [PATCH v4 1/2] net/ice: add RSS configuration for gtpu/pppoe Simei Su
2019-09-27 9:53 ` [dpdk-dev] [PATCH v4 2/2] net/ice: enable advanced RSS Simei Su
2019-09-29 10:30 ` [dpdk-dev] [PATCH v5 0/2] " Simei Su
2019-09-29 10:30 ` [dpdk-dev] [PATCH v5 1/2] net/ice: add RSS configuration for gtpu/pppoe Simei Su
2019-09-29 10:30 ` [dpdk-dev] [PATCH v5 2/2] net/ice: enable advanced RSS Simei Su
2019-09-30 0:28 ` [dpdk-dev] [PATCH v5 0/2] " Zhang, Qi Z
2019-10-16 22:16 ` [dpdk-dev] [PATCH v6 " Simei Su
2019-10-16 22:16 ` [dpdk-dev] [PATCH v6 1/2] net/ice: add RSS configuration for gtpu/pppoe Simei Su
2019-10-16 22:16 ` [dpdk-dev] [PATCH v6 2/2] net/ice: enable advanced RSS Simei Su
2019-10-20 2:14 ` [dpdk-dev] [PATCH v7 0/2] " Simei Su
2019-10-20 2:14 ` [dpdk-dev] [PATCH v7 1/2] net/ice: add RSS configuration for gtpu/pppoe Simei Su
2019-10-20 2:14 ` [dpdk-dev] [PATCH v7 2/2] net/ice: enable advanced RSS Simei Su
2019-10-21 12:06 ` [dpdk-dev] [PATCH v8 0/3] " Simei Su
2019-10-21 12:06 ` [dpdk-dev] [PATCH v8 1/3] net/ice: add RSS configuration for gtpu/pppoe Simei Su
2019-10-21 12:06 ` [dpdk-dev] [PATCH v8 2/3] net/ice: change one member type of the pattern structure Simei Su
2019-10-21 14:16 ` Ye Xiaolong
2019-10-21 17:30 ` Ferruh Yigit
2019-10-21 12:06 ` [dpdk-dev] [PATCH v8 3/3] net/ice: enable advanced RSS Simei Su
2019-10-21 17:30 ` Ferruh Yigit
2019-10-22 2:04 ` Ye Xiaolong [this message]
2019-10-21 14:24 ` [dpdk-dev] [PATCH v8 0/3] " Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022020418.GA23673@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).