From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: prefix cmdline numeric enum
Date: Fri, 25 Oct 2019 09:24:37 -0700 [thread overview]
Message-ID: <20191025092437.06c3cf49@hermes.lan> (raw)
In-Reply-To: <20191025105541.GC1755@bricha3-MOBL.ger.corp.intel.com>
On Fri, 25 Oct 2019 11:55:41 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Thu, Oct 24, 2019 at 11:09:26AM -0700, Stephen Hemminger wrote:
> > The values in an enum are really global names and not specific
> > to the enum in question. This can lead to namespace conflicts
> > in applications if a common value is visible.
> >
> > The DPDK cmdline API has an enum for numeric type values with
> > names line UINT32 which could be used or defined in a user
> > application. Change these to be prefixed with the enum name
> > like other places in DPDK.
> >
> > Lots of lines changed with no change in actual code
> > generated.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
>
> Duplicate of this patch from 6 months ago?
> http://patches.dpdk.org/patch/52644/
>
> /Bruce
Yes. one of them should go in.
Checkpatch spits out lots of noise because existing
code does not conform to style.
prev parent reply other threads:[~2019-10-25 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 18:09 Stephen Hemminger
2019-10-25 10:55 ` Bruce Richardson
2019-10-25 16:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025092437.06c3cf49@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).