From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: refine public interface
Date: Wed, 5 Feb 2020 02:08:47 +0300 [thread overview]
Message-ID: <20200205020847.3827b05f@Sovereign> (raw)
In-Reply-To: <2019930.Icojqenx9y@xps>
> I agree bloating rte_os.h is a concern.
> If you can achieve the initial goal (no specific include in apps, libs
> and drivers) while reducing rte_os.h, I think it is good.
<rte_windows.h> would be such a specific include, like <rte_kni_common.h> in
Linux EAL. This file would include Windows platform SDK files in the right
order, define feature macros and maybe error-handling macros, so that EAL
users could just access Windows SDK in one line without being bothered by
details and having handy macros as a bonus.
> This file is compiled only on Windows.
> What do you mean with "portable"?
By "portable" I mean not breaking OS-independent code with Windows defines.
Item 1 gives "min", "max" and "ERROR" macros as examples. Also, some Windows
includes must come after the others, e.g. <winsock2.h> (Berkeley sockets) must
come strictly after <windows.h>, and it's not an isolated case.
> > Fixes: 428eb983 ("eal: add OS specific header file")
>
> nit: blank line missing here
Thanks, I've little experience sending patches.
--
Dmitry Kozlyuk
prev parent reply other threads:[~2020-02-04 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 5:24 Dmitry Kozlyuk
2020-02-04 22:00 ` Thomas Monjalon
2020-02-04 23:08 ` Dmitry Kozlyuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205020847.3827b05f@Sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).