From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 6/6] net/null: add argument for no Rx
Date: Mon, 2 Mar 2020 17:36:45 +0000 [thread overview]
Message-ID: <20200302173646.54984-6-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20200302173646.54984-1-ferruh.yigit@intel.com>
Add an new device argument 'no-rx', which will prevent PMD receiving
packets.
This is useful for testing when a PMD is needed only to send packets to.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
doc/guides/nics/null.rst | 4 +++
drivers/net/null/rte_eth_null.c | 55 ++++++++++++++++++++++++++++++++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/null.rst b/doc/guides/nics/null.rst
index 405edf07b..c68d0d605 100644
--- a/doc/guides/nics/null.rst
+++ b/doc/guides/nics/null.rst
@@ -37,3 +37,7 @@ Runtime Config Options
$RTE_TARGET/app/testpmd -l 0-3 -n 4 --vdev "net_null0,size=256" -- -i
+- ``no-rx`` [optional, default disabled]
+
+ Makes PMD more like ``/dev/null``. On Rx no packets received, on Tx all packets are freed.
+ This option can't co-exist with ``copy`` option.
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 2c08ebf8c..11258ccea 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -14,13 +14,16 @@
#define ETH_NULL_PACKET_SIZE_ARG "size"
#define ETH_NULL_PACKET_COPY_ARG "copy"
+#define ETH_NULL_PACKET_NO_RX_ARG "no-rx"
static unsigned int default_packet_size = 64;
static unsigned int default_packet_copy;
+static unsigned int default_no_rx;
static const char *valid_arguments[] = {
ETH_NULL_PACKET_SIZE_ARG,
ETH_NULL_PACKET_COPY_ARG,
+ ETH_NULL_PACKET_NO_RX_ARG,
NULL
};
@@ -39,11 +42,13 @@ struct null_queue {
struct pmd_options {
unsigned int packet_copy;
unsigned int packet_size;
+ unsigned int no_rx;
};
struct pmd_internals {
unsigned int packet_size;
unsigned int packet_copy;
+ unsigned int no_rx;
uint16_t port_id;
struct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];
@@ -126,6 +131,13 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
return i;
}
+static uint16_t
+eth_null_no_rx(void *q __rte_unused, struct rte_mbuf **bufs __rte_unused,
+ uint16_t nb_bufs __rte_unused)
+{
+ return 0;
+}
+
static uint16_t
eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
{
@@ -504,6 +516,7 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args)
internals = eth_dev->data->dev_private;
internals->packet_size = args->packet_size;
internals->packet_copy = args->packet_copy;
+ internals->no_rx = args->no_rx;
internals->port_id = eth_dev->data->port_id;
rte_eth_random_addr(internals->eth_addr.addr_bytes);
@@ -526,6 +539,9 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args)
if (internals->packet_copy) {
eth_dev->rx_pkt_burst = eth_null_copy_rx;
eth_dev->tx_pkt_burst = eth_null_copy_tx;
+ } else if (internals->no_rx) {
+ eth_dev->rx_pkt_burst = eth_null_no_rx;
+ eth_dev->tx_pkt_burst = eth_null_tx;
} else {
eth_dev->rx_pkt_burst = eth_null_rx;
eth_dev->tx_pkt_burst = eth_null_tx;
@@ -569,6 +585,24 @@ get_packet_copy_arg(const char *key __rte_unused,
return 0;
}
+static int
+get_packet_no_rx_arg(const char *key __rte_unused,
+ const char *value, void *extra_args)
+{
+ const char *a = value;
+ unsigned int no_rx;
+
+ if (value == NULL || extra_args == NULL)
+ return -EINVAL;
+
+ no_rx = (unsigned int)strtoul(a, NULL, 0);
+ if (no_rx != 0 && no_rx != 1)
+ return -1;
+
+ *(unsigned int *)extra_args = no_rx;
+ return 0;
+}
+
static int
rte_pmd_null_probe(struct rte_vdev_device *dev)
{
@@ -576,6 +610,7 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)
struct pmd_options args = {
.packet_copy = default_packet_copy,
.packet_size = default_packet_size,
+ .no_rx = default_no_rx,
};
struct rte_kvargs *kvlist = NULL;
struct rte_eth_dev *eth_dev;
@@ -602,6 +637,9 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)
if (internals->packet_copy) {
eth_dev->rx_pkt_burst = eth_null_copy_rx;
eth_dev->tx_pkt_burst = eth_null_copy_tx;
+ } else if (internals->no_rx) {
+ eth_dev->rx_pkt_burst = eth_null_no_rx;
+ eth_dev->tx_pkt_burst = eth_null_tx;
} else {
eth_dev->rx_pkt_burst = eth_null_rx;
eth_dev->tx_pkt_burst = eth_null_tx;
@@ -627,6 +665,20 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)
&get_packet_copy_arg, &args.packet_copy);
if (ret < 0)
goto free_kvlist;
+
+ ret = rte_kvargs_process(kvlist,
+ ETH_NULL_PACKET_NO_RX_ARG,
+ &get_packet_no_rx_arg, &args.no_rx);
+ if (ret < 0)
+ goto free_kvlist;
+
+ if (args.no_rx && args.packet_copy) {
+ PMD_LOG(ERR,
+ "Both %s and %s arguments at the same time not supported",
+ ETH_NULL_PACKET_COPY_ARG,
+ ETH_NULL_PACKET_NO_RX_ARG);
+ goto free_kvlist;
+ }
}
PMD_LOG(INFO, "Configure pmd_null: packet size is %d, "
@@ -675,7 +727,8 @@ RTE_PMD_REGISTER_VDEV(net_null, pmd_null_drv);
RTE_PMD_REGISTER_ALIAS(net_null, eth_null);
RTE_PMD_REGISTER_PARAM_STRING(net_null,
"size=<int> "
- "copy=<int>");
+ "copy=<int> "
+ ETH_NULL_PACKET_NO_RX_ARG "=0|1");
RTE_INIT(eth_null_init_log)
{
--
2.24.1
next prev parent reply other threads:[~2020-03-02 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:36 [dpdk-dev] [PATCH 1/6] net/null: fix secondary burst function selection Ferruh Yigit
2020-03-02 17:36 ` [dpdk-dev] [PATCH 2/6] doc: add net null PMD guide Ferruh Yigit
2020-03-02 17:36 ` [dpdk-dev] [PATCH 3/6] net/null: remove redundant check Ferruh Yigit
2020-03-02 17:36 ` [dpdk-dev] [PATCH 4/6] net/null: prefer unsigned int Ferruh Yigit
2020-03-02 17:36 ` [dpdk-dev] [PATCH 5/6] net/null: group device arguments Ferruh Yigit
2020-03-02 17:36 ` Ferruh Yigit [this message]
2020-04-07 8:38 ` [dpdk-dev] [PATCH 1/6] net/null: fix secondary burst function selection Ferruh Yigit
2020-04-10 8:33 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302173646.54984-6-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).