From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Itsuro Oda <oda@valinux.co.jp>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: make iotlb cache name unique among multi processes
Date: Tue, 10 Mar 2020 19:32:06 +0800 [thread overview]
Message-ID: <20200310113206.GA14733@intel.com> (raw)
In-Reply-To: <20200310050003.16728-1-oda@valinux.co.jp>
On 03/10, Itsuro Oda wrote:
>Currently, iotlb cache name is comprised of vid and virtqueue
>index. For example, "iotlb_cache_0_0". Because vid is assigned
>per process, iotlb cache name is not unique among multi processes.
>For example a secondary process uses a vhost
>(ex. eth_vhost0,iface=/tmp/sock0) and another secondary process
>uses a vhost (ex. eth_vhost1,iface=/tmp/sock1), iotlb cache
>name of both vhost ("iotlb_cache_0_0") are same and as a result
>iotlb cache is broken.
>
>This patch makes iotlb cache name unique among milti processes
>by using the interface name not vid to comprise iotlb cache name.
>Since the length of interface name is variable, this patch uses
>hash value calculated by the interface name.
>
>Fixes: d012d1f293f4 (vhost: add IOTLB helper functions)
>Cc: stable@dpdk.org
>
>Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
>---
> lib/librte_vhost/iotlb.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c
>index bc1758528..0992c145b 100644
>--- a/lib/librte_vhost/iotlb.c
>+++ b/lib/librte_vhost/iotlb.c
>@@ -6,6 +6,7 @@
> #include <numaif.h>
> #endif
>
>+#include <rte_jhash.h>
> #include <rte_tailq.h>
>
> #include "iotlb.h"
>@@ -288,6 +289,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index)
> char pool_name[RTE_MEMPOOL_NAMESIZE];
> struct vhost_virtqueue *vq = dev->virtqueue[vq_index];
> int socket = 0;
>+ uint32_t val;
>
> if (vq->iotlb_pool) {
> /*
>@@ -308,8 +310,10 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index)
> TAILQ_INIT(&vq->iotlb_list);
> TAILQ_INIT(&vq->iotlb_pending_list);
>
>- snprintf(pool_name, sizeof(pool_name), "iotlb_cache_%d_%d",
>- dev->vid, vq_index);
>+ val = rte_jhash(dev->ifname, strlen(dev->ifname), 0);
>+ snprintf(pool_name, sizeof(pool_name), "iotlb_cache_%08x_%d",
>+ val, vq_index);
>+ VHOST_LOG_CONFIG(DEBUG, "IOTLB cache name: %s\n", pool_name);
>
> /* If already created, free it and recreate */
> vq->iotlb_pool = rte_mempool_lookup(pool_name);
>--
>2.17.0
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2020-03-10 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 5:00 Itsuro Oda
2020-03-10 11:32 ` Ye Xiaolong [this message]
2020-03-10 12:44 ` [dpdk-stable] [dpdk-dev] " Van Haaren, Harry
2020-03-10 12:58 ` Maxime Coquelin
2020-03-11 0:24 ` [dpdk-stable] [PATCH v2] " Itsuro Oda
2020-03-11 23:19 ` [dpdk-stable] [PATCH v3] " Itsuro Oda
2020-04-09 14:25 ` Maxime Coquelin
2020-04-10 14:45 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310113206.GA14733@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=oda@valinux.co.jp \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).