From: Wei Zhao <wei.zhao1@intel.com>
To: wei.zhao1@intel.com
Cc: stable@dpdk.org
Subject: [dpdk-stable] [PATCH 6/7] net/ice: add action number check for swicth
Date: Fri, 13 Mar 2020 10:04:48 +0800 [thread overview]
Message-ID: <20200313020449.21518-7-wei.zhao1@intel.com> (raw)
In-Reply-To: <20200313020449.21518-1-wei.zhao1@intel.com>
The action number can only be one for DCF or PF
switch filter, not support large action.
Cc: stable@dpdk.org
Fixes: 47d460d63233 ("net/ice: rework switch filter")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ice/ice_switch_filter.c | 48 +++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 7ca922602..48d689deb 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1079,6 +1079,46 @@ ice_switch_parse_action(struct ice_pf *pf,
return -rte_errno;
}
+static int
+ice_switch_check_action(const struct rte_flow_action *actions,
+ struct rte_flow_error *error)
+{
+ const struct rte_flow_action *action;
+ enum rte_flow_action_type action_type;
+ uint16_t actions_num = 0;
+
+ for (action = actions; action->type !=
+ RTE_FLOW_ACTION_TYPE_END; action++) {
+ action_type = action->type;
+ switch (action_type) {
+ case RTE_FLOW_ACTION_TYPE_VF:
+ case RTE_FLOW_ACTION_TYPE_RSS:
+ case RTE_FLOW_ACTION_TYPE_QUEUE:
+ case RTE_FLOW_ACTION_TYPE_DROP:
+ actions_num++;
+ break;
+ case RTE_FLOW_ACTION_TYPE_VOID:
+ continue;
+ default:
+ rte_flow_error_set(error,
+ EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "Invalid action type");
+ return -rte_errno;
+ }
+ }
+
+ if (actions_num > 1) {
+ rte_flow_error_set(error,
+ EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "Invalid action number");
+ return -rte_errno;
+ }
+
+ return 0;
+}
+
static int
ice_switch_parse_pattern_action(struct ice_adapter *ad,
struct ice_pattern_match_item *array,
@@ -1164,6 +1204,14 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
goto error;
}
+ ret = ice_switch_check_action(actions, error);
+ if (ret) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
+ "Invalid input action number");
+ goto error;
+ }
+
if (ad->hw.dcf_enabled)
ret = ice_switch_parse_dcf_action(actions, error, &rule_info);
else
--
2.19.1
next prev parent reply other threads:[~2020-03-13 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200313020449.21518-1-wei.zhao1@intel.com>
2020-03-13 2:04 ` [dpdk-stable] [PATCH 5/7] net/ice: change default tunnle type Wei Zhao
2020-03-13 2:04 ` Wei Zhao [this message]
2020-03-13 2:04 ` [dpdk-stable] [PATCH 7/7] net/ice: fix input set of VLAN item Wei Zhao
[not found] <20200313022540.21984-1-wei.zhao1@intel.com>
2020-03-13 2:25 ` [dpdk-stable] [PATCH 6/7] net/ice: add action number check for swicth Wei Zhao
[not found] <20200313020806.21654-1-wei.zhao1@intel.com>
2020-03-13 2:08 ` Wei Zhao
2020-03-13 2:06 [dpdk-stable] [PATCH 0/7] add switch filter support for intel DCF Wei Zhao
2020-03-13 2:07 ` [dpdk-stable] [PATCH 6/7] net/ice: add action number check for swicth Wei Zhao
[not found] <20200313020147.21394-1-wei.zhao1@intel.com>
2020-03-13 2:01 ` Wei Zhao
[not found] <20200313020023.21341-1-wei.zhao1@intel.com>
2020-03-13 2:00 ` Wei Zhao
[not found] <20200313014006.19589-1-wei.zhao1@intel.com>
2020-03-13 1:40 ` Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313020449.21518-7-wei.zhao1@intel.com \
--to=wei.zhao1@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).