From: Stephen Hemminger <stephen@networkplumber.org>
To: Chenxu Di <chenxux.di@intel.com>
Cc: dev@dpdk.org, Yang Qiming <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/4] drivers/net: remove legacy filter API and switch to rte flow
Date: Tue, 17 Mar 2020 20:00:13 -0700 [thread overview]
Message-ID: <20200317200013.230a3a57@hermes.lan> (raw)
In-Reply-To: <20200318014710.13577-1-chenxux.di@intel.com>
On Wed, 18 Mar 2020 01:47:06 +0000
Chenxu Di <chenxux.di@intel.com> wrote:
> remove legacy filter functions already implemented in rte_flow
> for drivers igb, ixgbe, and i40e.
> implement hash function include set hash function and set hash
> input set in rte_flow for driver i40e.
>
> Chenxu Di (4):
> net/e1000: remove the legacy filter functions
> net/ixgbe: remove the legacy filter functions
> net/i40e: remove the legacy filter functions
> net/i40e: implement hash function in rte flow API
>
> doc/guides/nics/i40e.rst | 14 +
> doc/guides/rel_notes/release_20_05.rst | 9 +
> drivers/net/e1000/igb_ethdev.c | 36 -
> drivers/net/i40e/i40e_ethdev.c | 913 +++++++++++--------------
> drivers/net/i40e/i40e_ethdev.h | 26 +-
> drivers/net/i40e/i40e_fdir.c | 393 -----------
> drivers/net/i40e/i40e_flow.c | 186 ++++-
> drivers/net/ixgbe/ixgbe_ethdev.c | 78 ---
> drivers/net/ixgbe/ixgbe_fdir.c | 11 -
> 9 files changed, 610 insertions(+), 1056 deletions(-)
>
This looks like an API break for users using the legacy filter API.
Even though filter_ctrl is marked as deprecated. That probably has
to wait for 20.11 until it is removed. At that point, drop the ethdev
ops handle, the rte_eth_dev_filter_ctrl API (etc) and fix all the test
code.
next prev parent reply other threads:[~2020-03-18 3:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 1:47 Chenxu Di
2020-03-18 1:47 ` [dpdk-dev] [PATCH 1/4] net/e1000: remove the legacy filter functions Chenxu Di
2020-03-18 3:15 ` Yang, Qiming
2020-03-18 1:47 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: " Chenxu Di
2020-03-18 1:47 ` [dpdk-dev] [PATCH 3/4] net/i40e: " Chenxu Di
2020-03-18 1:47 ` [dpdk-dev] [PATCH 4/4] net/i40e: implement hash function in rte flow API Chenxu Di
2020-03-18 3:00 ` Stephen Hemminger [this message]
2020-03-19 6:39 ` [dpdk-dev] [PATCH v2] " Chenxu Di
2020-03-20 1:24 ` [dpdk-dev] [PATCH v3] " Chenxu Di
2020-03-23 8:25 ` [dpdk-dev] [PATCH v4] " Chenxu Di
2020-03-24 3:28 ` Yang, Qiming
2020-03-24 8:17 ` [dpdk-dev] [PATCH v5] " Chenxu Di
2020-03-24 12:57 ` Iremonger, Bernard
[not found] ` <87688dbf6ac946d5974a61578be1ed89@intel.com>
2020-03-25 9:48 ` Iremonger, Bernard
2020-03-27 12:49 ` Xing, Beilei
2020-03-30 7:40 ` [dpdk-dev] [PATCH v6] " Chenxu Di
2020-04-02 16:26 ` Iremonger, Bernard
[not found] ` <4a1f49493dc54ef0b3ae9c2bf7018f0d@intel.com>
2020-04-08 8:24 ` Iremonger, Bernard
2020-04-10 1:52 ` Xing, Beilei
2020-04-13 5:31 ` [dpdk-dev] [PATCH v7] net/i40e: enable advanced RSS Chenxu Di
2020-04-14 6:36 ` [dpdk-dev] [PATCH v8] " Chenxu Di
2020-04-14 14:55 ` Iremonger, Bernard
2020-04-15 5:31 ` Xing, Beilei
2020-04-15 8:46 ` [dpdk-dev] [PATCH v9] net/i40e: enable hash configuration in RSS flow Chenxu Di
2020-04-15 9:52 ` Xing, Beilei
2020-04-15 9:59 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317200013.230a3a57@hermes.lan \
--to=stephen@networkplumber.org \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).