DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	Jerin Jacob <jerinjacobk@gmail.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global
Date: Fri, 3 Apr 2020 10:35:58 +0100	[thread overview]
Message-ID: <20200403093558.GA547@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zcBY-mMNPpKwNVATY6pmm5ui3KNQrXBzDgpearMbCGqQ@mail.gmail.com>

On Fri, Apr 03, 2020 at 11:14:03AM +0200, David Marchand wrote:
> On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > diff --git a/drivers/meson.build b/drivers/meson.build
> > > index 987e616ae7..4d8f842ab8 100644
> > > --- a/drivers/meson.build
> > > +++ b/drivers/meson.build
> > > @@ -20,7 +20,7 @@ dpdk_driver_classes = ['common',
> > >  disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'),
> > >                 ).stdout().split()
> > >
> > > -default_cflags = machine_args
> > > +default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']
> > >  if cc.has_argument('-Wno-format-truncation')
> > >         default_cflags += '-Wno-format-truncation'
> > >  endif
> >
> > I see nothing wrong with that.
> >
> > Out of interest, is there a reason we don't just set it at the top level as
> > a project c_arg, e.g. after setting "-include rte_config.h" in
> > config/meson.build?
> 
> As long as it is not inherited by examples and external apps, I am
> fine with any simple solution :-).
> 
It will be inherited by everything inside the current build, but building
any examples separately or any external apps separately won't be affected.

/Bruce

  reply	other threads:[~2020-04-03  9:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 18:32 [dpdk-dev] " Jerin Jacob
2020-04-02 18:32 ` [dpdk-dev] [PATCH v2 2/2] build: makefile " Jerin Jacob
2020-04-03  7:23 ` [dpdk-dev] [PATCH v2 1/2] build: meson " David Marchand
2020-04-03  7:45   ` David Marchand
2020-04-03  8:05     ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-04-03  8:18       ` David Marchand
2020-04-03  9:10         ` Bruce Richardson
2020-04-03  9:14           ` David Marchand
2020-04-03  9:35             ` Bruce Richardson [this message]
2020-04-03 10:56       ` Thomas Monjalon
2020-04-03 11:02         ` Pavan Nikhilesh Bhagavatula
2020-04-03 10:20 ` [dpdk-dev] " Hemant Agrawal (OSS)
2020-04-03 14:19 ` [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally pbhagavatula
2020-04-06 20:16   ` David Marchand
2020-04-10  9:03   ` [dpdk-dev] [PATCH v4] build: enable allow experimental API flag pbhagavatula
2020-04-10 12:12     ` David Marchand
2020-04-10 15:48       ` David Marchand
2020-04-13 14:55 ` [dpdk-dev] [PATCH v5] build: disable experimental API check internally David Marchand
2020-04-14 14:23   ` David Marchand
2020-04-17 10:21     ` Trahe, Fiona
2020-04-17 13:23       ` David Marchand
2020-04-17 13:44         ` Trahe, Fiona
2020-04-17 13:54           ` Thomas Monjalon
2020-04-17 13:56           ` David Marchand
2020-04-17 15:05             ` Trahe, Fiona
2020-04-17 15:52               ` Trahe, Fiona
2020-04-18 19:43                 ` Chautru, Nicolas
2020-04-19  7:35                   ` David Marchand
2020-04-19 16:17                     ` Chautru, Nicolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403093558.GA547@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pbhagavatula@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).