From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
Boris Pismenny <borisp@mellanox.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Anoob Joseph <anoob.joseph@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters
Date: Thu, 9 Apr 2020 12:13:24 +0100 [thread overview]
Message-ID: <20200409111324.GC613@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <22404743.ouqheUzb2q@thomas>
On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote:
> 09/04/2020 12:14, Bruce Richardson:
> > On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote:
> > > 08/04/2020 17:49, Lukasz Wojciechowski:
> > > > Hi guys,
> > > >
> > > > I don't know what is the current status of "legacy" build using
> > > > gnumakes, so I added the new DEBUG flag to config just as it was done in
> > > > other libs like eventdev.
> > > > Many guides still point config files as the one that should be changed
> > > > in order to enable some features, so I thought I should add it there.
> > > >
> > > > If I understand well the official build system now is the one based on
> > > > using meson and ninja, however it hasn't got anything similar to the
> > > > gnamakefiles system, e.g.
> > > > in the meson.build file for libraries all the libraries have build
> > > > variable set to true and there are few ifs that check it, but as it's
> > > > set to true all libraries build always.
> > > > And each library considered there defines RTE_LIBRTE_[LIBRARY_NAME].
> > > > It's kind of weird.
> > > >
> > > > foreach l:libraries
> > > > * build = true**
> > > > * reason = '<unknown reason>' # set if build == false to explain why
> > > > ...
> > > > * if not build*
> > > > dpdk_libs_disabled += name
> > > > set_variable(name.underscorify() + '_disable_reason', reason)
> > > > else
> > > > enabled_libs += name
> > > > *dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)*
> > > > ...
> > > >
> > > > Have you think about reusing config files in meson configuration and
> > > > have a single point of configuration? Of course all meson flags can
> > > > overwrite the default config.
> > >
> > > This is on purpose.
> > > We are removing most of compile-time options with meson.
> > >
> > > I think we can use a global option for debug-specific code.
> > > Bruce, what do you recommend?
> > >
> > Meson has a built-in global debug setting which could be used. However,
> > that may be too course-grained. If that is the case there are a couple of
> > options:
> >
> > 1 Each library can have it's own debug flag defined, which is set on
> > the commandline in CFLAGS. Can be done right now - just reuse any of the
> > debug variables in the existing make config files (stripping off the
> > CONFIG_), e.g. CFLAGS=-DRTE_MALLOC_DEBUG
> > 2 Since that is perhaps not the most usable - though easiest to implement -
> > we can look to add a general debug option (or couple of options) in
> > meson, e.g. debug_libs=, debug_drivers=, where each option takes a list of
> > libs or drivers to pass the debug flags to. This will require a little
> > work in the meson build infrastructure, but is not that hard. The harder
> > part is standardizing the debug flags across all components.
> >
> > The advantage of #1 is that it works today and just needs some
> > documentation for each lib/driver what it's debug flags are. The advantage
> > of #2 is more usability, but it requires a lot more work to standardize
> > IMHO.
>
> In this case, we need a general option as the one already provided by meson.
> It means: "I am not in production, I want to see anything behaving wrong
> in the datapath."
> "Anything" means we don't need a per-library switch.
> And for the other needs (out of fast path), we have a new function:
> rte_log_can_log(mylogtype, RTE_LOG_DEBUG)
>
To use the general option in meson something like below is probably all
that is needed to flag the debug build to all components:
diff --git a/config/meson.build b/config/meson.build
index 49482091d..b01cd1251 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -176,6 +176,10 @@ endif
# add -include rte_config to cflags
add_project_arguments('-include', 'rte_config.h', language: 'c')
+if get_option('debug')
+ add_project_arguments('-DDEBUG', language: 'c')
+endif
+
# enable extra warnings and disable any unwanted warnings
warning_flags = [
# -Wall is added by meson by default, so add -Wextra only
next prev parent reply other threads:[~2020-04-09 11:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200312151654.7218-1-l.wojciechow@partner.samsung.com>
[not found] ` <20200408031351.4288-1-l.wojciechow@partner.samsung.com>
[not found] ` <CGME20200408031447eucas1p1376332353faa0d217e7be8c32271405f@eucas1p1.samsung.com>
2020-04-08 3:13 ` [dpdk-stable] " Lukasz Wojciechowski
2020-04-08 12:54 ` Thomas Monjalon
2020-04-08 13:02 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
2020-04-08 13:26 ` Thomas Monjalon
2020-04-08 14:44 ` [dpdk-stable] [EXT] " Anoob Joseph
2020-04-08 15:49 ` Lukasz Wojciechowski
2020-04-08 17:51 ` Thomas Monjalon
2020-04-09 10:14 ` Bruce Richardson
2020-04-09 10:54 ` Thomas Monjalon
2020-04-09 11:13 ` Bruce Richardson [this message]
2020-04-09 14:07 ` Lukasz Wojciechowski
2020-04-09 14:21 ` Lukasz Wojciechowski
2020-04-09 15:22 ` Thomas Monjalon
2020-04-09 16:10 ` Lukasz Wojciechowski
2020-04-10 8:45 ` Bruce Richardson
[not found] ` <CGME20200408031448eucas1p2b36997fc73f5b5e2aadb6e4bb965063b@eucas1p2.samsung.com>
2020-04-08 3:13 ` [dpdk-stable] [PATCH v2 02/13] security: fix return types in documentation Lukasz Wojciechowski
[not found] ` <CGME20200408031448eucas1p2d6df7ff419bb093606a2f9115297f45a@eucas1p2.samsung.com>
2020-04-08 3:13 ` [dpdk-stable] [PATCH v2 03/13] security: fix session counter Lukasz Wojciechowski
[not found] ` <CGME20200408031449eucas1p1ca89719463cbaf29e9f7c81beaec88c2@eucas1p1.samsung.com>
2020-04-08 3:13 ` [dpdk-stable] [PATCH v2 04/13] app/test: fix macro definition Lukasz Wojciechowski
2020-04-08 12:53 ` Thomas Monjalon
2020-04-08 16:15 ` Lukasz Wojciechowski
2020-04-08 17:47 ` Thomas Monjalon
2020-04-09 14:10 ` Lukasz Wojciechowski
[not found] ` <20200409172502.1693-1-l.wojciechow@partner.samsung.com>
[not found] ` <CGME20200409172529eucas1p1f02aaf66052f45ac75ba9e9f63ef1c3a@eucas1p1.samsung.com>
2020-04-09 17:24 ` [dpdk-stable] [PATCH v3 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-13 15:42 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
[not found] ` <CGME20200409172530eucas1p27297a83a9d7508e3f8a8f88850cbe37c@eucas1p2.samsung.com>
2020-04-09 17:24 ` [dpdk-stable] [PATCH v3 02/13] security: fix return types in documentation Lukasz Wojciechowski
2020-04-13 15:43 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
[not found] ` <CGME20200409172531eucas1p1c3ec21532e5e232ff2d68d56f096e71c@eucas1p1.samsung.com>
2020-04-09 17:24 ` [dpdk-stable] [PATCH v3 03/13] security: fix session counter Lukasz Wojciechowski
2020-04-13 15:48 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
[not found] ` <CGME20200409172532eucas1p285bc6767be1d62a0098d177a7757169f@eucas1p2.samsung.com>
2020-04-09 17:24 ` [dpdk-stable] [PATCH v3 04/13] app/test: remove macro definition Lukasz Wojciechowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409111324.GC613@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=anoobj@marvell.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=l.wojciechow@partner.samsung.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).