From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] test/security: enable tests for non-implemented ops
Date: Thu, 23 Apr 2020 18:25:54 +0200 [thread overview]
Message-ID: <20200423162554.23529-1-l.wojciechow@partner.samsung.com> (raw)
In-Reply-To: <20200423151042.4650-1-konstantin.ananyev@intel.com>
After re-enabling checks for non-implemneted ops in non-debug mode
in librte_security set_pkt_metadata and get_userdata functions,
tests verifying proper work of tests can be enabled also.
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
---
app/test/test_security.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/app/test/test_security.c b/app/test/test_security.c
index 724ce56f4..3076a4c5a 100644
--- a/app/test/test_security.c
+++ b/app/test/test_security.c
@@ -1474,7 +1474,6 @@ test_set_pkt_metadata_inv_context_ops(void)
static int
test_set_pkt_metadata_inv_context_ops_fun(void)
{
-#ifdef RTE_DEBUG
struct security_unittest_params *ut_params = &unittest_params;
struct rte_mbuf m;
int params;
@@ -1487,9 +1486,6 @@ test_set_pkt_metadata_inv_context_ops_fun(void)
TEST_ASSERT_MOCK_CALLS(mock_set_pkt_metadata_exp, 0);
return TEST_SUCCESS;
-#else
- return TEST_SKIPPED;
-#endif
}
/**
@@ -1621,7 +1617,6 @@ test_get_userdata_inv_context_ops(void)
static int
test_get_userdata_inv_context_ops_fun(void)
{
-#ifdef RTE_DEBUG
struct security_unittest_params *ut_params = &unittest_params;
uint64_t md = 0xDEADBEEF;
ut_params->ctx.ops = &empty_ops;
@@ -1632,9 +1627,6 @@ test_get_userdata_inv_context_ops_fun(void)
TEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0);
return TEST_SUCCESS;
-#else
- return TEST_SKIPPED;
-#endif
}
/**
--
2.17.1
next prev parent reply other threads:[~2020-04-23 16:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 23:51 [dpdk-dev] [PATCH] security: fix crash at accessing " Konstantin Ananyev
2020-04-23 0:11 ` Ananyev, Konstantin
2020-04-23 7:58 ` Lukasz Wojciechowski
2020-04-23 4:07 ` Anoob Joseph
2020-04-23 7:54 ` Ananyev, Konstantin
2020-04-23 8:06 ` Lukasz Wojciechowski
2020-04-23 8:11 ` Ananyev, Konstantin
2020-04-23 8:22 ` Ananyev, Konstantin
2020-04-23 9:09 ` Anoob Joseph
2020-04-23 10:54 ` Ananyev, Konstantin
2020-04-23 11:23 ` Anoob Joseph
2020-04-23 12:55 ` Akhil Goyal
2020-04-23 13:30 ` Lukasz Wojciechowski
2020-04-23 13:47 ` Ananyev, Konstantin
2020-04-23 14:08 ` Akhil Goyal
2020-04-23 14:48 ` Ananyev, Konstantin
2020-04-23 8:00 ` Lukasz Wojciechowski
2020-04-23 8:28 ` Ananyev, Konstantin
2020-04-23 15:10 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
2020-04-23 15:51 ` Akhil Goyal
2020-04-23 16:08 ` Anoob Joseph
2020-04-23 16:14 ` Akhil Goyal
2020-04-23 16:29 ` Lukasz Wojciechowski
[not found] ` <CGME20200423162615eucas1p2224e9313aa640f755cf226649d093bb9@eucas1p2.samsung.com>
2020-04-23 16:25 ` Lukasz Wojciechowski [this message]
2020-05-09 21:47 ` [dpdk-dev] [PATCH] test/security: enable tests for " Akhil Goyal
2020-05-11 10:15 ` Lukasz Wojciechowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423162554.23529-1-l.wojciechow@partner.samsung.com \
--to=l.wojciechow@partner.samsung.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).