From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 00/11] rename blacklist/whitelist to exclude/include
Date: Mon, 13 Jul 2020 23:05:41 -0700 [thread overview]
Message-ID: <20200713230541.770cdabe@hermes.lan> (raw)
In-Reply-To: <20200714053919.5609-1-stephen@networkplumber.org>
On Mon, 13 Jul 2020 22:39:08 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> The terms blacklist and whitelist are often seen as reminders
> of the divisions in society. Instead, use more exact terms for
> handling of which devices are used in DPDK.
>
> This is a proposed change for DPDK 20.08 to replace the names
> blacklist and whitelist in API and command lines.
>
> The first three patches fix some other unnecessary use of
> blacklist/whitelist and have no user visible impact.
>
> The rest change the PCI blacklist to be blocklist and
> whitelist to be allowlist.
>
> Thank you for the support and review of this patch.
>
> v4 - change to use pci-include/pci-exclude for options
> incorporate review feedback
> keep old options (with approporiate deprecation notice)
> update examples in doc
>
> Stephen Hemminger (11):
> rte_ethdev: change comment to rte_dev_eth_mac_addr_add
> mk: replace reference to blacklist/whitelist
> check_maintainers: change variable names
> eal: replace usage of blacklist/whitelist in enum
> drivers: replace references to blacklist
> eal: replace pci-whitelist/pci-blacklist options
> doc: replace references to blacklist/whitelist
> app/test: use new allowlist and blocklist
> doc: add note about blacklist/whitelist changes
> eal: mark old macros for blacklist/whitelist as deprecated
> doc: update examples to new config options
>
> app/test/autotest.py | 16 ++---
> app/test/autotest_runner.py | 18 +++---
> app/test/test.c | 2 +-
> app/test/test_eal_flags.c | 52 ++++++++--------
> devtools/check-maintainers.sh | 8 +--
> doc/guides/cryptodevs/dpaa2_sec.rst | 4 +-
> doc/guides/cryptodevs/dpaa_sec.rst | 4 +-
> doc/guides/cryptodevs/qat.rst | 6 +-
> doc/guides/eventdevs/octeontx2.rst | 20 +++----
> doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +-
> doc/guides/linux_gsg/build_sample_apps.rst | 2 +-
> doc/guides/linux_gsg/eal_args.include.rst | 14 ++---
> doc/guides/linux_gsg/linux_drivers.rst | 4 +-
> doc/guides/mempool/octeontx2.rst | 4 +-
> doc/guides/nics/bnxt.rst | 6 +-
> doc/guides/nics/cxgbe.rst | 12 ++--
> doc/guides/nics/dpaa.rst | 4 +-
> doc/guides/nics/dpaa2.rst | 4 +-
> doc/guides/nics/enic.rst | 12 ++--
> doc/guides/nics/fail_safe.rst | 18 +++---
> doc/guides/nics/features.rst | 2 +-
> doc/guides/nics/i40e.rst | 12 ++--
> doc/guides/nics/ice.rst | 18 +++---
> doc/guides/nics/mlx4.rst | 16 ++---
> doc/guides/nics/mlx5.rst | 12 ++--
> doc/guides/nics/octeontx2.rst | 22 +++----
> doc/guides/nics/sfc_efx.rst | 2 +-
> doc/guides/nics/tap.rst | 10 ++--
> doc/guides/nics/thunderx.rst | 4 +-
> .../prog_guide/env_abstraction_layer.rst | 7 +--
> doc/guides/prog_guide/multi_proc_support.rst | 4 +-
> doc/guides/rel_notes/known_issues.rst | 4 +-
> doc/guides/rel_notes/release_20_08.rst | 6 ++
> doc/guides/rel_notes/release_2_1.rst | 2 +-
> doc/guides/sample_app_ug/bbdev_app.rst | 6 +-
> doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +-
> doc/guides/sample_app_ug/l3_forward.rst | 2 +-
> .../sample_app_ug/l3_forward_access_ctrl.rst | 2 +-
> .../sample_app_ug/l3_forward_power_man.rst | 2 +-
> doc/guides/sample_app_ug/vdpa.rst | 2 +-
> doc/guides/tools/cryptoperf.rst | 6 +-
> doc/guides/tools/flow-perf.rst | 2 +-
> drivers/bus/dpaa/dpaa_bus.c | 7 +--
> drivers/bus/fslmc/fslmc_bus.c | 9 ++-
> drivers/bus/fslmc/fslmc_vfio.c | 8 +--
> drivers/bus/pci/pci_common.c | 24 ++++----
> drivers/bus/vmbus/vmbus_common.c | 4 +-
> drivers/crypto/virtio/virtio_pci.c | 2 +-
> drivers/net/fm10k/fm10k_ethdev.c | 2 +-
> drivers/net/virtio/virtio_pci.c | 2 +-
> lib/librte_eal/common/eal_common_devargs.c | 14 ++---
> lib/librte_eal/common/eal_common_options.c | 59 ++++++++++++-------
> lib/librte_eal/common/eal_options.h | 8 ++-
> lib/librte_eal/include/rte_bus.h | 13 +++-
> lib/librte_eal/include/rte_dev.h | 12 +++-
> lib/librte_eal/include/rte_devargs.h | 12 +++-
> lib/librte_ethdev/rte_ethdev.h | 3 +-
> mk/rte.sdktest.mk | 14 ++---
> 58 files changed, 299 insertions(+), 255 deletions(-)
>
There are some bogus checkpatch complaints against patches in this
series. The new linux kernel checkpatch now complains about whitelist/blacklist
so any attempt to fix would hit that.
Also, Linux kernel checkpatch now wants the magic
fallthrough;
which in Linux kernel is a macro but does not exist in DPDK.
Someone want to fix checkpatch for that one?
prev parent reply other threads:[~2020-07-14 6:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 0:00 [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 01/10] rte_ethdev: change comment to rte_dev_eth_mac_addr_add Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 02/10] mk: replace reference to blacklist/whitelist Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 03/10] check_maintainers: change variable names Stephen Hemminger
2020-07-10 17:01 ` Thomas Monjalon
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 04/10] eal: replace usage of blacklist/whitelist in enum Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 05/10] drivers: replace references to blacklist Stephen Hemminger
2020-06-15 6:32 ` Hemant Agrawal
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 06/10] eal: replace pci-whitelist/pci-blacklist options Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 07/10] doc: replace references to blacklist/whitelist Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 08/10] app/test: use new allowlist and blocklist Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 09/10] doc: add note about blacklist/whitelist changes Stephen Hemminger
2020-06-13 0:00 ` [dpdk-dev] [PATCH v3 10/10] eal: mark old macros for blacklist/whitelist as deprecated Stephen Hemminger
2020-06-17 12:05 ` [dpdk-dev] [PATCH v3 00/10] rename blacklist/whitelist to block/allow Mcnamara, John
2020-07-10 15:06 ` David Marchand
2020-07-14 4:43 ` Stephen Hemminger
2020-07-14 5:33 ` Stephen Hemminger
2020-07-15 10:01 ` [dpdk-dev] [dpdk-techboard] " Thomas Monjalon
2020-09-22 14:28 ` Stephen Hemminger
2020-09-22 16:16 ` Thomas Monjalon
2020-09-22 16:18 ` Thomas Monjalon
2020-09-22 17:12 ` Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 00/11] rename blacklist/whitelist to exclude/include Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 01/11] rte_ethdev: change comment to rte_dev_eth_mac_addr_add Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 02/11] mk: replace reference to blacklist/whitelist Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 03/11] check_maintainers: change variable names Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 04/11] eal: replace usage of blacklist/whitelist in enum Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 05/11] drivers: replace references to blacklist Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 06/11] eal: replace pci-whitelist/pci-blacklist options Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 07/11] doc: replace references to blacklist/whitelist Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 08/11] app/test: use new allowlist and blocklist Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 09/11] doc: add note about blacklist/whitelist changes Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 10/11] eal: mark old macros for blacklist/whitelist as deprecated Stephen Hemminger
2020-07-14 5:39 ` [dpdk-dev] [PATCH v4 11/11] doc: update examples to new config options Stephen Hemminger
2020-07-14 6:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713230541.770cdabe@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).