From: Sarosh Arif <sarosh.arif@emumba.com>
To: erik.g.carrillo@intel.com, rsanford@akamai.com
Cc: dev@dpdk.org, Sarosh Arif <sarosh.arif@emumba.com>
Subject: [dpdk-dev] [PATCH] doc: announce API change in timer
Date: Mon, 3 Aug 2020 16:20:59 +0500 [thread overview]
Message-ID: <20200803112059.23328-1-sarosh.arif@emumba.com> (raw)
If the user tries to reset/stop some other timer in it's callback
function, which is also about to expire, using
rte_timer_reset_sync/rte_timer_stop_sync the application goes into
an infinite loop. This happens because
rte_timer_reset_sync/rte_timer_stop_sync loop until the timer
resets/stops and there is check inside timer_set_config_state which
prevents a running timer from being reset/stopped by not it's own
timer_cb. Therefore timer_set_config_state returns -1 due to which
rte_timer_reset returns -1 and rte_timer_reset_sync goes into an
infinite loop
To to prevent this rte_timer_reset_sync and rte_timer_stop_sync should
have int return types, so that -1 can be returned if the above condition
occurs
Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a4..ed93a707d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,9 @@ Deprecation Notices
Python 2 support will be completely removed in 20.11.
In 20.08, explicit deprecation warnings will be displayed when running
scripts with Python 2.
+
+* timer: Since timer can get stuck in an infinite loop if the application tries to
+ reset/stop some other timer in it's callback function, which is also about to
+ expire. The function ``rte_timer_stop_sync`` and ``rte_timer_stop_sync`` will
+ have a int return type in order to return with -1 in when this condition
+ occures.
--
2.17.1
next reply other threads:[~2020-08-03 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 11:20 Sarosh Arif [this message]
2020-08-03 16:45 ` Carrillo, Erik G
2020-08-03 23:16 ` Honnappa Nagarahalli
2020-08-04 3:28 ` Sarosh Arif
2020-08-04 14:24 ` Carrillo, Erik G
2020-08-04 20:50 ` Honnappa Nagarahalli
2020-08-04 3:51 ` [dpdk-dev] [PATCH v2] " Sarosh Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803112059.23328-1-sarosh.arif@emumba.com \
--to=sarosh.arif@emumba.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).