From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ed Czeck <ed.czeck@atomicrules.com>,
dev@dpdk.org, shepard.siegel@atomicrules.com,
john.miller@atomicrules.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control
Date: Mon, 24 Aug 2020 15:40:45 +0100 [thread overview]
Message-ID: <20200824144045.GA547@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <ff6884a6-f026-399e-09ca-d740e67412ce@intel.com>
On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote:
> On 8/24/2020 2:36 PM, Ed Czeck wrote:
> > Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG,
> > PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG.
> > Review and adjust log levels and messages as needed.
> >
> > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> > ---
> > doc/guides/nics/ark.rst | 13 ------
> > drivers/net/ark/ark_ddm.c | 12 ++---
> > drivers/net/ark/ark_ethdev.c | 77 +++++++++++++++------------------
> > drivers/net/ark/ark_ethdev_rx.c | 46 ++++++++++----------
> > drivers/net/ark/ark_ethdev_tx.c | 10 ++---
> > drivers/net/ark/ark_logs.h | 63 +++------------------------
> > drivers/net/ark/ark_mpu.c | 32 ++++----------
> > drivers/net/ark/ark_pktchkr.c | 36 +++++++--------
> > drivers/net/ark/ark_pktdir.c | 2 +-
> > drivers/net/ark/ark_pktgen.c | 22 +++++-----
> > drivers/net/ark/ark_rqp.c | 4 +-
> > drivers/net/ark/ark_udm.c | 18 ++++----
> > 12 files changed, 125 insertions(+), 210 deletions(-)
> >
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index 06e8c3374..c3ffcbbc2 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -132,19 +132,6 @@ Configuration Information
> > * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX
> > packets are padded to 60 bytes to support downstream MACS.
> >
> > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_RX** (default n): Enables or disables debug
> > - logging and internal checking of RX ingress logic within the ARK PMD driver.
> > -
> > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TX** (default n): Enables or disables debug
> > - logging and internal checking of TX egress logic within the ARK PMD driver.
> > -
> > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS** (default n): Enables or disables debug
> > - logging of detailed packet and performance statistics gathered in
> > - the PMD and FPGA.
> > -
> > - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE** (default n): Enables or disables debug
> > - logging of detailed PMD events and status.
> > -
>
> Can you please remove these config option from 'config/common_base'?
>
Given that the file is scheduled for deletion fairly soon, not sure if that
is worthwhile doing.
next prev parent reply other threads:[~2020-08-24 14:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 15:35 [dpdk-dev] [PATCH] net/ark: fix meson build Ed Czeck
2020-08-19 16:29 ` Ferruh Yigit
2020-08-19 20:45 ` Ed Czeck
2020-08-20 11:16 ` Ferruh Yigit
2020-08-20 15:41 ` Ed Czeck
2020-08-21 9:44 ` Ferruh Yigit
2020-08-20 21:55 ` [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control Ed Czeck
2020-08-20 21:55 ` [dpdk-dev] [PATCH 2/2] net/ark remove ARK_TX_PAD_TO_60 configuration macro Ed Czeck
2020-08-21 9:50 ` Ferruh Yigit
2020-08-24 13:36 ` [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control Ed Czeck
2020-08-24 13:36 ` [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro Ed Czeck
2020-08-24 14:55 ` Ferruh Yigit
2020-08-24 21:51 ` Ed Czeck
2020-08-25 7:43 ` Ferruh Yigit
2020-08-24 14:37 ` [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control Ferruh Yigit
2020-08-24 14:40 ` Bruce Richardson [this message]
2020-08-24 15:09 ` Ferruh Yigit
2020-08-24 21:40 ` Ed Czeck
2020-08-25 7:44 ` Ferruh Yigit
2020-08-26 15:24 ` Ed Czeck
2020-08-26 15:24 ` [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro Ed Czeck
2020-08-27 16:11 ` [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control Ed Czeck
2020-08-27 16:11 ` [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro Ed Czeck
2020-09-01 11:17 ` Ferruh Yigit
2020-09-08 19:20 ` [dpdk-dev] [PATCH v7 1/2] net/ark: remove compile time log macros in favor of run time log control Ed Czeck
2020-09-08 19:20 ` [dpdk-dev] [PATCH v7 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro Ed Czeck
2020-09-09 13:33 ` [dpdk-dev] [PATCH v7 1/2] net/ark: remove compile time log macros in favor of run time log control Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824144045.GA547@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=ferruh.yigit@intel.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).