From: Stephen Hemminger <stephen@networkplumber.org>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] net: adjust the header length parse size
Date: Tue, 8 Sep 2020 07:53:36 -0700 [thread overview]
Message-ID: <20200908075336.7d75195c@hermes.lan> (raw)
In-Reply-To: <20200907015651.956011-1-haiyue.wang@intel.com>
On Mon, 7 Sep 2020 09:56:50 +0800
Haiyue Wang <haiyue.wang@intel.com> wrote:
> Enlarge the L3 and tunnel header length from 8-bit to 16-bit to handle
> the bigger headers. And reorder the fields to avoid creating a structure
> hole.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: use bit field to avoid creating a structure hole.
> v3: use basic type and reorder to avoid structure hole.
> ---
> lib/librte_net/rte_net.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h
> index 94b06d9ee..434435ffa 100644
> --- a/lib/librte_net/rte_net.h
> +++ b/lib/librte_net/rte_net.h
> @@ -20,11 +20,11 @@ extern "C" {
> */
> struct rte_net_hdr_lens {
> uint8_t l2_len;
> - uint8_t l3_len;
> - uint8_t l4_len;
> - uint8_t tunnel_len;
> uint8_t inner_l2_len;
> - uint8_t inner_l3_len;
> + uint16_t l3_len;
> + uint16_t inner_l3_len;
> + uint16_t tunnel_len;
> + uint8_t l4_len;
> uint8_t inner_l4_len;
> };
>
Acked-by: Stephhen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2020-09-08 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 5:40 [dpdk-dev] [PATCH v1] net: expand the data size of L3 length to 16 bits Haiyue Wang
2020-09-04 18:55 ` Stephen Hemminger
2020-09-05 3:17 ` Wang, Haiyue
2020-09-05 3:06 ` [dpdk-dev] [PATCH v2] net: adjust the header length parse size Haiyue Wang
2020-09-05 16:56 ` Stephen Hemminger
2020-09-07 2:14 ` Wang, Haiyue
2020-09-07 1:56 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2020-09-08 14:53 ` Stephen Hemminger [this message]
2020-09-18 8:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908075336.7d75195c@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).