From: Harry van Haaren <harry.van.haaren@intel.com>
To: dev@dpdk.org
Cc: Harry van Haaren <harry.van.haaren@intel.com>
Subject: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant
Date: Fri, 11 Sep 2020 10:19:19 +0100 [thread overview]
Message-ID: <20200911091919.62167-1-harry.van.haaren@intel.com> (raw)
This commit adds a new rte_prefetch0_write() variant, suggests to the
compiler to use a prefetch instruction with intention to write. As a
compiler builtin, the compiler can choose based on compilation target
what the best implementation for this instruction is.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
The integer constants passed to the builtin are not available as
a #define value, and doing #defines just for this write variant
does not seems a nice solution to me... particularly for those using
IDEs where any #define value is auto-hinted for code-completion.
---
lib/librte_eal/include/generic/rte_prefetch.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/lib/librte_eal/include/generic/rte_prefetch.h b/lib/librte_eal/include/generic/rte_prefetch.h
index 6e47bdfbad..44e2e9abfc 100644
--- a/lib/librte_eal/include/generic/rte_prefetch.h
+++ b/lib/librte_eal/include/generic/rte_prefetch.h
@@ -51,4 +51,20 @@ static inline void rte_prefetch2(const volatile void *p);
*/
static inline void rte_prefetch_non_temporal(const volatile void *p);
+/**
+ * Prefetch a cache line into all cache levels, with intention to write. This
+ * prefetch variant hints to the CPU that the program is expecting to write to
+ * the cache line being prefetched.
+ *
+ * @param p Address to prefetch
+ */
+static inline void rte_prefetch0_write(const void *p)
+{
+ /* 1 indicates intention to write, 3 sets target cache level to L1. See
+ * GCC docs where these integer constants are described in more detail:
+ * https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
+ */
+ __builtin_prefetch(p, 1, 3);
+}
+
#endif /* _RTE_PREFETCH_H_ */
--
2.17.1
next reply other threads:[~2020-09-11 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 9:19 Harry van Haaren [this message]
2020-09-13 20:11 ` Pavan Nikhilesh Bhagavatula
2020-09-14 8:12 ` Van Haaren, Harry
2020-09-14 10:39 ` Pavan Nikhilesh Bhagavatula
2020-09-14 15:10 ` Van Haaren, Harry
2020-09-14 15:10 ` [dpdk-dev] [PATCH v2] eal: add new prefetch write variants Harry van Haaren
2020-10-08 7:42 ` David Marchand
2020-10-08 8:34 ` Van Haaren, Harry
2020-10-08 8:39 ` Van Haaren, Harry
2020-10-08 8:54 ` Jerin Jacob
2020-10-10 10:21 ` Ruifeng Wang
2020-10-15 8:18 ` David Marchand
2020-10-15 8:44 ` Van Haaren, Harry
2020-10-15 10:32 ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2020-10-15 20:27 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911091919.62167-1-harry.van.haaren@intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).