From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: david.marchand@redhat.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility
Date: Wed, 30 Sep 2020 17:19:47 +0100 [thread overview]
Message-ID: <20200930161947.GB977@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <4d0ad859-a0bc-7a75-ef1c-fa5c794a07d8@intel.com>
On Wed, Sep 30, 2020 at 05:12:50PM +0100, Ferruh Yigit wrote:
> On 9/16/2020 5:44 PM, Bruce Richardson wrote:
> > As flagged previously on-list, there are a number of macros used to specify
> > what libs and drivers are enabled in the build which differ from the
> > equivalents used with make. This patchset is one possible approach to
> > fixing these, but as part of the investigation some issues were hit where
> > I'd like additional input to ensure we are ok with the approach taken in
> > this set.
> >
> > First, a problem statement:
> >
> > * While the make build defines generally followed a pattern, there were
> > many instances where the defines were unique. These can be seen in the
> > values defined in patch 4.
> >
> > * The NIC PMDs had two separate standards for the defines - some (the
> > physical device drivers) tended to have the _PMD at the end of the
> > macros, while the virtual drivers had it in the middle. Since the
> > majority seemed to go with it at the end, meson chose this option.
> > However, as can be seen from patch 4, a number now need special handling
> > for compatibility
>
> +1 to all X_PMD macros.
>
> >
> > * This "_PMD" at the end made its way into other device classes, such as
> > crypto and event, but it appears that the standard for these classes from
> > make is in fact the opposite. Therefore we have had for the last 2+ years
> > conflicting macros for crypto, compression and event classes.
> >
> > * There is also the question of how important compatibility for these
> > macros is, especially since we have had numerous incompatibilities
> > without it being reported before. There is also the issue of the
> > deprecation process for macros, since these are not part of any ABI.
> >
> > What's done in this set:
> >
> > * Firstly, and missing dependencies on apps or examples had to be fixed,
> > where a dependency was missed because it was never needed due to the code
> > being stripped out because of a missing macro.
> >
> > * Secondly, since it is likely that use of the defines from make is more
> > widespread than those from meson, the defines for the crypto, compression
> > and event classes are changed to align with the make values. Just in case
> > though, temporary code is added to drivers/meson.build to redefine the
> > old meson values too, and a deprecation notice is added for these. The
> > hope is that we can then remove this temporary code in the next release,
> > leaving us with just one macro style for each driver class.
> >
> > * Thirdly, we add an additional set of backward compatibility macros for
> > the ~30 special-cases, where the meson macro template does not match that
> > defined for make. Again, this is intended to be temporary and a
> > deprecation notice is given for the macros in that file.
> >
>
> Why we need this backward compatibility? The macros are to enable/disable a
> module, so isn't it DPDK internal.
> If we enable the macros for new naming convention and update the build
> system and code for new macros, will it affect the end user?
>
I'd love to be able to just take this option, but the macros are used to
indicate to applications what drivers or other components can be expected
to be available - much as the case for testpmd. Ideally, they should not be
necessary.
I think the best approach is that proposed earlier on this thread - we keep
backward compatibility as much as possible in this release, but add in a
new set of standardized macros and a deprecation notice about the old ones.
I hope to work on a new rev of this patchset shortly.
/Bruce
next prev parent reply other threads:[~2020-09-30 16:19 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 16:44 Bruce Richardson
2020-09-16 16:44 ` [dpdk-dev] [RFC PATCH 1/5] app: fix missing dependencies Bruce Richardson
2020-09-16 16:44 ` [dpdk-dev] [RFC PATCH 2/5] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-09-16 16:44 ` [dpdk-dev] [RFC PATCH 3/5] meson: fix compatibility with make build defines Bruce Richardson
2020-09-16 16:44 ` [dpdk-dev] [RFC PATCH 4/5] build: add defines for compatibility with make build Bruce Richardson
2020-09-16 16:44 ` [dpdk-dev] [RFC PATCH 5/5] build: replace use of old build macros Bruce Richardson
2020-09-17 17:59 ` [dpdk-dev] [RFC PATCH 0/5] rework feature enabling macros for compatibility Andrew Rybchenko
2020-09-18 8:41 ` Bruce Richardson
2020-09-18 8:59 ` Andrew Rybchenko
2020-09-18 12:19 ` Ferruh Yigit
2020-09-23 12:46 ` Thomas Monjalon
2020-09-30 16:49 ` Richardson, Bruce
2020-09-30 17:31 ` Thomas Monjalon
2020-09-18 15:12 ` David Marchand
2020-09-30 16:12 ` Ferruh Yigit
2020-09-30 16:19 ` Bruce Richardson [this message]
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 0/8] Rework build macros Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 1/8] app: fix missing dependencies Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 3/8] build: add defines for compatibility with make build Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 4/8] qat: build from common folder Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 5/8] build: remove library name from version map filename Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 6/8] build: standardize component names and defines Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 7/8] build: replace use of old build macros Bruce Richardson
2020-10-02 15:58 ` [dpdk-dev] [RFC PATCH v2 8/8] [v21.02] build: remove compatibility build defines Bruce Richardson
2020-10-14 14:12 ` [dpdk-dev] [PATCH v3 0/7] Rework build macros Bruce Richardson
2020-10-14 14:12 ` [dpdk-dev] [PATCH v3 1/7] app: fix missing dependencies Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:12 ` [dpdk-dev] [PATCH v3 2/7] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:13 ` [dpdk-dev] [PATCH v3 3/7] build: add defines for compatibility with make build Bruce Richardson
2020-10-15 10:31 ` Luca Boccassi
2020-10-15 11:20 ` Bruce Richardson
2020-10-14 14:13 ` [dpdk-dev] [PATCH v3 4/7] qat: build from common folder Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:13 ` [dpdk-dev] [PATCH v3 5/7] build: remove library name from version map filename Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-14 14:13 ` [dpdk-dev] [PATCH v3 6/7] build: standardize component names and defines Bruce Richardson
2020-10-15 10:30 ` Luca Boccassi
2020-10-15 11:18 ` Bruce Richardson
2020-10-15 13:05 ` Luca Boccassi
2020-10-15 14:03 ` Bruce Richardson
2020-10-15 15:32 ` Luca Boccassi
2020-10-15 15:34 ` Bruce Richardson
2020-10-14 14:13 ` [dpdk-dev] [PATCH v3 7/7] build: replace use of old build macros Bruce Richardson
2020-10-15 10:32 ` Luca Boccassi
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 0/8] Rework " Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 1/8] app: fix missing dependencies Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 3/8] build: add defines for compatibility with make build Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 4/8] qat: build from common folder Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 5/8] build: remove library name from version map filename Bruce Richardson
2020-10-18 11:56 ` Xu, Rosen
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 6/8] devtools/test-null: load all drivers from directory Bruce Richardson
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 7/8] build: standardize component names and defines Bruce Richardson
2020-10-18 11:55 ` Xu, Rosen
2020-10-15 11:03 ` [dpdk-dev] [PATCH v4 8/8] build: replace use of old build macros Bruce Richardson
2020-10-18 11:55 ` Xu, Rosen
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 0/8] Rework " Bruce Richardson
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 1/8] app: fix missing dependencies Bruce Richardson
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 2/8] examples/l2fwd-crypto: fix missing dependency Bruce Richardson
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 3/8] build: add defines for compatibility with make build Bruce Richardson
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 4/8] qat: build from common folder Bruce Richardson
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 5/8] build: remove library name from version map filename Bruce Richardson
2020-10-15 15:28 ` Andrew Rybchenko
2020-10-19 20:04 ` Thomas Monjalon
2020-10-18 9:24 ` Xu, Rosen
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory Bruce Richardson
2020-10-19 16:58 ` Thomas Monjalon
2020-10-20 8:37 ` Bruce Richardson
2020-10-20 10:01 ` Thomas Monjalon
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 7/8] build: standardize component names and defines Bruce Richardson
2020-10-15 15:32 ` Andrew Rybchenko
2020-10-15 15:35 ` Bruce Richardson
2020-10-18 9:21 ` Xu, Rosen
2020-10-15 15:05 ` [dpdk-dev] [PATCH v5 8/8] build: replace use of old build macros Bruce Richardson
2020-10-15 15:34 ` Andrew Rybchenko
2020-10-18 9:23 ` Xu, Rosen
2020-10-19 19:03 ` Thomas Monjalon
2020-10-19 20:27 ` [dpdk-dev] [PATCH v5 0/8] Rework " Thomas Monjalon
2020-10-20 7:17 ` David Marchand
2020-10-20 8:37 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930161947.GB977@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).