From: Stephen Hemminger <stephen@networkplumber.org>
To: nhorman@tuxdriver.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v2 4/7] dpdk-pmdinfo: replace is False and is True
Date: Tue, 3 Nov 2020 22:48:39 -0800 [thread overview]
Message-ID: <20201104064842.25832-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20201104064842.25832-1-stephen@networkplumber.org>
Code reads better if unnecessary comparison with False and True
is not used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
usertools/dpdk-pmdinfo.py | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index c9ecf45a72f3..8c4698063fb4 100755
--- a/usertools/dpdk-pmdinfo.py
+++ b/usertools/dpdk-pmdinfo.py
@@ -375,7 +375,7 @@ def search_for_autoload_path(self):
":/usr/lib64:/lib64:/usr/lib:/lib")
if library is None:
return (None, None)
- if raw_output is False:
+ if not raw_output:
print("Scanning for autoload path in %s" % library)
scanfile = open(library, 'rb')
scanelf = ReadElf(scanfile, sys.stdout)
@@ -451,7 +451,7 @@ def process_dt_needed_entries(self):
runpath + ":" + ldlibpath +
":/usr/lib64:/lib64:/usr/lib:/lib")
if library is not None:
- if raw_output is False:
+ if not raw_output:
print("Scanning %s for pmd information" % library)
with open(library, 'rb') as file:
try:
@@ -481,7 +481,7 @@ def force_bytes(s):
def scan_autoload_path(autoload_path):
global raw_output
- if os.path.exists(autoload_path) is False:
+ if not os.path.exists(autoload_path):
return
try:
@@ -505,7 +505,7 @@ def scan_autoload_path(autoload_path):
# No permission to read the file, skip it
continue
- if raw_output is False:
+ if not raw_output:
print("Hw Support for library %s" % d)
readelf.display_pmd_info_strings(".rodata")
file.close()
@@ -518,8 +518,8 @@ def scan_for_autoload_pmds(dpdk_path):
"""
global raw_output
- if os.path.isfile(dpdk_path) is False:
- if raw_output is False:
+ if not os.path.isfile(dpdk_path):
+ if not raw_output:
print("Must specify a file name")
return
@@ -527,22 +527,22 @@ def scan_for_autoload_pmds(dpdk_path):
try:
readelf = ReadElf(file, sys.stdout)
except ElfError:
- if raw_output is False:
+ if not raw_output:
print("Unable to parse %s" % file)
return
(autoload_path, scannedfile) = readelf.search_for_autoload_path()
if not autoload_path:
- if raw_output is False:
+ if not raw_output:
print("No autoload path configured in %s" % dpdk_path)
return
- if raw_output is False:
+ if not raw_output:
if scannedfile is None:
scannedfile = dpdk_path
print("Found autoload path %s in %s" % (autoload_path, scannedfile))
file.close()
- if raw_output is False:
+ if not raw_output:
print("Discovered Autoload HW Support:")
scan_autoload_path(autoload_path)
return
@@ -601,14 +601,14 @@ def main(stream=None):
optparser.print_usage()
exit(1)
- if options.pdir is True:
+ if options.pdir:
exit(scan_for_autoload_pmds(args[0]))
ldlibpath = os.environ.get('LD_LIBRARY_PATH')
if ldlibpath is None:
ldlibpath = ""
- if os.path.exists(args[0]) is True:
+ if os.path.exists(args[0]):
myelffile = args[0]
else:
myelffile = search_file(
--
2.27.0
next prev parent reply other threads:[~2020-11-04 6:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 1:31 [dpdk-dev] [PATCH 00/11] Python script updates Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 01/11] cpu_layout: refactor to meet python standards Stephen Hemminger
2020-11-04 6:53 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-11-04 9:21 ` Bruce Richardson
2020-11-04 16:22 ` Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 02/11] dpdk-pmdinfo: replace string.split with split Stephen Hemminger
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 0/7] dpdk-pmdinfo: python lint cleanups Stephen Hemminger
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 1/7] dpdk-pmdinfo: replace string.split with split Stephen Hemminger
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 2/7] dpdk-pmdinfo: replace io.open with open Stephen Hemminger
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 3/7] dpdk-pmdinfo: remove unnecessary paren and else Stephen Hemminger
2020-11-04 6:48 ` Stephen Hemminger [this message]
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 5/7] dpdk-pmdinfo: fix indentation Stephen Hemminger
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 6/7] dpdk-pmdinfo: replace deprecated optparse with argparse Stephen Hemminger
2020-11-24 6:35 ` Jiang, YuX
2020-11-04 6:48 ` [dpdk-dev] [PATCH v2 7/7] dpdk-pmdinfo: do not use len(x) to test for empty Stephen Hemminger
2020-11-22 20:54 ` [dpdk-dev] [PATCH v2 0/7] dpdk-pmdinfo: python lint cleanups Thomas Monjalon
2020-09-06 1:31 ` [dpdk-dev] [PATCH 03/11] dpdk-pmdinfo: replace io.open with open Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 04/11] dpdk-pmdinfo: remove dead code Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 05/11] dpdk-pmdinfo: remove unnecessary paren and else Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 06/11] dpdk-pmdinfo: replace is False and is True Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 07/11] dpdk-pmdinfo: fix indentation Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 08/11] dpdk-pmdinfo: replace deprecated optparse with argparse Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 09/11] dpdk-pmdinfo: do not use len(x) to test for empty Stephen Hemminger
2020-09-07 9:03 ` Bruce Richardson
2020-09-07 17:20 ` Stephen Hemminger
2020-09-06 1:31 ` [dpdk-dev] [PATCH 10/11] dpdk-telemetry-client: fix some pylint warnings Stephen Hemminger
2020-09-07 9:05 ` Bruce Richardson
2020-11-04 7:00 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-11-15 23:06 ` Thomas Monjalon
2020-09-06 1:31 ` [dpdk-dev] [PATCH 11/11] dpdk-devbind: use argparse instead of getopt Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 0/6] dpdk-devbind: python lint cleanups Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 1/6] dpdk-devbind: use argparse instead of getopt Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 2/6] dpdk-devbind: fix indentation Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 3/6] dpdk-devbind: fix python lint warnings for imports Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 4/6] dpdk-devbind: do not use len(x) to test for empty Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 5/6] dpdk-devbind: fix unnecessary else after return Stephen Hemminger
2020-11-04 7:03 ` [dpdk-dev] [PATCH v2 6/6] dpdk-devbind: use in to test for multiple strings Stephen Hemminger
2020-11-04 9:28 ` [dpdk-dev] [PATCH v2 0/6] dpdk-devbind: python lint cleanups Bruce Richardson
2020-11-22 21:03 ` Thomas Monjalon
2020-11-04 16:57 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104064842.25832-5-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).