From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
Cc: dev@dpdk.org, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix segfault with gcc 5.x
Date: Wed, 06 Apr 2016 11:27:17 +0200 [thread overview]
Message-ID: <2020208.0hTbuSh3Wa@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B2E246@irsmsx105.ger.corp.intel.com>
> > It seems that with gcc >5.x and -O2/-O3 optimization breaks packet grouping
> > algorithm.
> >
> > When last packet pointer "lp" and "pnum->u64" buffer points the same
> > memory buffer, high optimization can cause unpredictable results. It seems
> > that assignment of precalculated group sizes may interfere with
> > initialization of new group size when lp points value inside current group
> > and didn't should be changed.
> >
> > With gcc >5.x and optimization we cannot be sure which assignment will be
> > done first, so the group size can be counted incorrectly.
> >
> > This patch eliminates intersection of assignment of initial group size
> > (lp[0] = 1) and precalculated group sizes when gptbl[v].idx < 4.
> >
> > Fixes: 94c54b4158d5 ("examples/l3fwd: rework exact-match")
> >
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-04-06 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 14:45 Tomasz Kulasek
2016-04-04 15:34 ` Ananyev, Konstantin
2016-04-04 15:51 ` De Lara Guarch, Pablo
2016-04-04 16:20 ` Kulasek, TomaszX
2016-04-04 19:05 ` Ananyev, Konstantin
2016-04-05 12:02 ` Kulasek, TomaszX
2016-04-04 19:06 ` Ananyev, Konstantin
2016-04-06 9:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2020208.0hTbuSh3Wa@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).