From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, david.marchand@redhat.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 2/3] build: hide debug messages in non-developer mode
Date: Thu, 25 Feb 2021 15:29:02 +0000 [thread overview]
Message-ID: <20210225152903.148347-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20210225152903.148347-1-bruce.richardson@intel.com>
The messages about what components have what dependency names, and
information about function versioning not being supported on windows are
only of interest to developers, so hide them when building in
non-developer mode.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 6 ++++--
lib/meson.build | 10 ++++++----
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index fdf76120ac..b26051c21c 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -208,8 +208,10 @@ foreach subpath:subdirs
set_variable('shared_@0@'.format(lib_name), shared_dep)
set_variable('static_@0@'.format(lib_name), static_dep)
dependency_name = ''.join(lib_name.split('rte_'))
- message('drivers/@0@: Defining dependency "@1@"'.format(
- drv_path, dependency_name))
+ if developer_mode
+ message('drivers/@0@: Defining dependency "@1@"'.format(
+ drv_path, dependency_name))
+ endif
endif # build
endforeach
diff --git a/lib/meson.build b/lib/meson.build
index 7712aa4977..b378050299 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -115,9 +115,9 @@ foreach l:libraries
shared_dep = declare_dependency(include_directories: includes)
static_dep = shared_dep
else
- if is_windows and use_function_versioning
+ if is_windows and use_function_versioning and developer_mode
message('@0@: Function versioning is not supported by Windows.'
- .format(name))
+ .format(name))
endif
if use_function_versioning
@@ -206,7 +206,9 @@ foreach l:libraries
set_variable('shared_rte_' + name, shared_dep)
set_variable('static_rte_' + name, static_dep)
- message('lib/@0@: Defining dependency "@1@"'.format(
- dir_name, name))
+ if developer_mode
+ message('lib/@0@: Defining dependency "@1@"'.format(
+ dir_name, name))
+ endif
endif # if build
endforeach
--
2.27.0
next prev parent reply other threads:[~2021-02-25 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 15:29 [dpdk-dev] [PATCH 0/3] Add developer mode to DPDK build Bruce Richardson
2021-02-25 15:29 ` [dpdk-dev] [PATCH 1/3] build: enable a developer mode setting Bruce Richardson
2021-02-25 15:29 ` Bruce Richardson [this message]
2021-02-25 15:29 ` [dpdk-dev] [PATCH 3/3] build: limit symbol checks to developer mode Bruce Richardson
2021-02-25 19:50 ` [dpdk-dev] [PATCH 0/3] Add developer mode to DPDK build Thomas Monjalon
2021-04-09 17:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225152903.148347-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).