From: Bruce Richardson <bruce.richardson@intel.com>
To: Gabriel Ganne <gabriel.ganne@6wind.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
Thierry Herbelot <thierry.herbelot@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version
Date: Tue, 23 Mar 2021 09:38:25 +0000 [thread overview]
Message-ID: <20210323093825.GA1158@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAGFdkHQAi5+JxWmLTqB8O3xW+BkE_EB+=XqV5TOs+KAkd0RoqQ@mail.gmail.com>
On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote:
> Hi,
> Thanks for the review.
> I have some reservations about those TODO: they are about
> rewriting the same functionality with a newer meson feature.
> No functional change is expected. => Why not write a commit that
> implements such a TODO and bumps meson version at the same time
> independently ?
> In any case, I aimed to set meson's required version to the lowest
> possible value
> so that distributions would have a chance to provide it. I know we can
> just
> install meson using pip, but it might be nice not to need this.
> Below are some versions of meson packages as of today:
> pip: 0.57.1
> rhel-8: 0.49.2
> debian-10: 0.49.2
> ubuntu-18.04: 0.45.1
> ubuntu-20.04: 0.53.2
> Going over 0.49.2 will cause DPDK to lose some major distribution's
> stable release,
> at least out-of-the-box through their respective package manager.
> I propose to bump to 0.49.2 here, and leave the TODOs to wait a little
> longer.
+1
However, I don't think we need the ".2" specifically, since new features
don't come in point releases, so I'd suggest just making "0.49" the
minimum.
next prev parent reply other threads:[~2021-03-23 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 8:38 Gabriel Ganne
2021-03-22 8:39 ` [dpdk-dev] [PATCH 2/3] meson: use threads dependency as provided by meson Gabriel Ganne
2021-03-22 8:39 ` [dpdk-dev] [PATCH 3/3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-03-22 9:34 ` [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version Bruce Richardson
2021-03-22 15:25 ` Dmitry Kozlyuk
2021-03-23 6:22 ` Gabriel Ganne
2021-03-23 7:16 ` Andrew Rybchenko
2021-03-23 7:42 ` Dmitry Kozlyuk
2021-03-23 9:38 ` Bruce Richardson [this message]
2021-04-01 11:09 ` Bruce Richardson
2021-03-22 13:57 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323093825.GA1158@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=gabriel.ganne@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).