From: Shijith Thotton <shijith.thotton@gmail.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: Shijith Thotton <sthotton@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix case to initiate crypto adapter service
Date: Tue, 13 Apr 2021 13:21:24 +0530 [thread overview]
Message-ID: <20210413075124.GA21@BG-LT7405.marvell.com> (raw)
In-Reply-To: <DM6PR11MB35488D285671414B3DB8E4AAE84F9@DM6PR11MB3548.namprd11.prod.outlook.com>
On Tue, Apr 13, 2021 at 04:08:40AM +0000, Gujjar, Abhinandan S wrote:
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Monday, April 12, 2021 2:24 PM
> > To: dev@dpdk.org
> > Cc: Shijith Thotton <sthotton@marvell.com>; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; Akhil
> > Goyal <gakhil@marvell.com>; Anoob Joseph <anoobj@marvell.com>
> > Subject: [PATCH v2] eventdev: fix case to initiate crypto adapter service
> >
> > Initiate software crypto adapter service, only if hardware capabilities are not
> > reported. In OP_FORWARD mode, software service is not required to
> > enqueue events if OP_FORWARD capability is supported by the PMD.
> >
> > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > ---
> > v2:
> > - Reworded commit message.
> >
> > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c
> > b/lib/librte_eventdev/rte_event_crypto_adapter.c
> > index d903cdd48..e1d38d383 100644
> > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t
> > id,
> > * b. OP_NEW mode -> SW Dequeue
> > */
> > if ((cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
> > + !(cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> The same check is below ORed with above condition.
> This is confusing. Could you recheck & do the necessary changes?
>
As per comments above, below checks are used to initiate SW service if:
1. PMDs supports OP_NEW, but not OP_FWD, in FWD mode.
2. Does not support OP_NEW and OP_FWD.
I have fixed the first point where only support for OP_NEW is checked in forward
mode, by adding a check for no OP_FWD capability.
> > adapter->mode ==
> > RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) ||
> > (!(cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
> > !(cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> > --
> > 2.25.1
>
next prev parent reply other threads:[~2021-04-13 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 7:08 [dpdk-dev] [PATCH v1] " Shijith Thotton
2021-04-12 7:30 ` Jerin Jacob
2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton
2021-04-13 4:08 ` Gujjar, Abhinandan S
2021-04-13 7:51 ` Shijith Thotton [this message]
2021-04-14 7:06 ` Gujjar, Abhinandan S
2021-04-17 17:24 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413075124.GA21@BG-LT7405.marvell.com \
--to=shijith.thotton@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).