From: Stephen Hemminger <stephen@networkplumber.org>
To: Tudor Cornea <tudor.cornea@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity
Date: Wed, 3 Nov 2021 15:18:02 -0700 [thread overview]
Message-ID: <20211103151802.5f233118@hermes.local> (raw)
In-Reply-To: <CAOuQ8vUxkryO-dXF3CK6A97czTfWdMDsAC+-rXEvoQEnq_fOeg@mail.gmail.com>
On Wed, 3 Nov 2021 22:40:51 +0200
Tudor Cornea <tudor.cornea@gmail.com> wrote:
> On Tue, 2 Nov 2021 at 17:53, Stephen Hemminger <stephen@networkplumber.org>
> wrote:
>
> > On Tue, 2 Nov 2021 17:51:13 +0200
> > Tudor Cornea <tudor.cornea@gmail.com> wrote:
> >
> > > +#ifdef RTE_KNI_PREEMPT_DEFAULT
> > > +module_param(min_scheduling_interval, long, 0644);
> > > +MODULE_PARM_DESC(min_scheduling_interval,
> > > +"Kni thread min scheduling interval (default=100 microseconds):\n"
> > > +"\t\t"
> > > +);
> >
> > Why the non-standard newline's and tab's?
> > Please try to make KNI look like other kernel code.
> >
>
> Hi Stephen,
>
> I tried to base the description of the new parameters on an existing
> parameter implemented for the rte_kni module - carrier.
>
> module_param(carrier, charp, 0644);
> MODULE_PARM_DESC(carrier,
> "Default carrier state for KNI interface (default=off):\n"
> "\t\toff Interfaces will be created with carrier state set to off.\n"
> "\t\ton Interfaces will be created with carrier state set to on.\n"
> "\t\t"
> );
>
> I thought about keeping the compatibility in terms of coding style with the
> existing Kni module parameters.
> Upon browsing the Linux tree, I realise it might not be standard (
> checkpatch.pl , interestingly didn't seem to complain about the patch)
>
> I also realise now, that I missed two tabs at the beginning of the params
> description.
> Should I add the missing tabs, so that the new parameters that I intend to
> add through this patch are similar in style to the existing ones, or should
> I remove the newlines and tabs altogether, when specifying the description
> for min_scheduling_interval and max_scheduling_interval ?
>
> Thanks,
> Tudor
Although KNI is unlikely to ever get upstream code review, there
is no reason to deviate from common practice in kernel drivers.
The original module parameter was doing something unconventional.
Not wrong, just different.
next prev parent reply other threads:[~2021-11-03 22:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 10:38 [dpdk-dev] [PATCH] " Tudor Cornea
2021-11-02 15:51 ` [dpdk-dev] [PATCH v2] " Tudor Cornea
2021-11-02 15:53 ` Stephen Hemminger
2021-11-03 20:40 ` Tudor Cornea
2021-11-03 22:18 ` Stephen Hemminger [this message]
2021-11-08 10:13 ` [dpdk-dev] [PATCH v3] " Tudor Cornea
2021-11-22 17:31 ` Ferruh Yigit
2021-11-23 17:08 ` Ferruh Yigit
2021-11-24 17:10 ` Tudor Cornea
2021-11-24 19:24 ` [PATCH v4] " Tudor Cornea
2022-01-14 13:53 ` Connolly, Padraig J
2022-01-14 14:13 ` Ferruh Yigit
2022-01-14 15:18 ` [PATCH v5] " Tudor Cornea
2022-01-14 16:24 ` Stephen Hemminger
2022-01-14 16:43 ` Ferruh Yigit
2022-01-17 16:24 ` Tudor Cornea
2022-01-20 12:41 ` [PATCH v6] " Tudor Cornea
2022-02-02 19:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103151802.5f233118@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=tudor.cornea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).