DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Ray Kinsella <mdr@ashroe.eu>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Andrew Boyer <aboyer@pensando.io>,
	Beilei Xing <beilei.xing@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Chas Williams <chas3@att.com>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	Ciara Loftus <ciara.loftus@intel.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	Gaetan Rivet <grive@u256.net>, Gagandeep Singh <g.singh@nxp.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	Haiyue Wang <haiyue.wang@intel.com>,
	Harman Kalra <hkalra@marvell.com>,
	heinrich.kuhn@corigine.com,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	Igor Chauskin <igorch@amazon.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Jakub Grajciar <jgrajcia@cisco.com>,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Jian Wang <jianwang@trustnetic.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	John Daley <johndale@cisco.com>,
	John Miller <john.miller@atomicrules.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Wiles, Keith" <keith.wiles@intel.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Lijun Ou <oulijun@huawei.com>, Liron Himi <lironh@marvell.com>,
	Long Li <longli@microsoft.com>, Marcin Wojtas <mw@semihalf.com>,
	Martin Spinler <spinler@cesnet.cz>,
	Matan Azrad <matan@nvidia.com>,
	Matt Peters <matt.peters@windriver.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Michal Krawczyk <mk@semihalf.com>,
	"Min Hu (Connor" <humin29@huawei.com>,
	Pradeep Kumar Nalla <pnalla@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Radha Mohan Chintakuntla <radhac@marvell.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Rasesh Mody <rmody@marvell.com>, Rosen Xu <rosen.xu@intel.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
	Shahed Shaikh <shshaikh@marvell.com>,
	Shai Brandes <shaibran@amazon.com>,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	Somalapuram Amaranath <asomalap@amd.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Steven Webster <steven.webster@windriver.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	Veerasenareddy Burru <vburru@marvell.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Xiao Wang <xiao.w.wang@intel.com>,
	Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Yong Wang <yongwang@vmware.com>,
	Ziyang Xuan <xuanziyang2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: support queue-based priority flow control
Date: Sun, 5 Dec 2021 10:00:31 -0800	[thread overview]
Message-ID: <20211205100031.7be8e7b0@hermes.local> (raw)
In-Reply-To: <CALBAE1NYzb0AHCN0krd0RmkNAaU2xFUF2mS=byHvKbJRd6HK4Q@mail.gmail.com>

On Sun, 5 Dec 2021 12:33:57 +0530
Jerin Jacob <jerinjacobk@gmail.com> wrote:

> On Sat, Dec 4, 2021 at 11:08 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Sat, 4 Dec 2021 22:54:58 +0530
> > <jerinj@marvell.com> wrote:
> >  
> > > +     /**
> > > +      * Maximum supported traffic class as per PFC (802.1Qbb) specification.
> > > +      *
> > > +      * Based on device support and use-case need, there are two different
> > > +      * ways to enable PFC. The first case is the port level PFC
> > > +      * configuration, in this case, rte_eth_dev_priority_flow_ctrl_set()
> > > +      * API shall be used to configure the PFC, and PFC frames will be
> > > +      * generated using based on VLAN TC value.
> > > +      * The second case is the queue level PFC configuration, in this case,
> > > +      * Any packet field content can be used to steer the packet to the
> > > +      * specific queue using rte_flow or RSS and then use
> > > +      * rte_eth_dev_priority_flow_ctrl_queue_set() to set the TC mapping
> > > +      * on each queue. Based on congestion selected on the specific queue,
> > > +      * configured TC shall be used to generate PFC frames.
> > > +      *
> > > +      * When set to non zero value, application must use queue level
> > > +      * PFC configuration via rte_eth_dev_priority_flow_ctrl_queue_set() API
> > > +      * instead of port level PFC configuration via
> > > +      * rte_eth_dev_priority_flow_ctrl_set() API to realize
> > > +      * PFC configuration.
> > > +      */
> > > +     uint8_t pfc_queue_tc_max;
> > > +     uint8_t reserved_8s[7];
> > > +     uint64_t reserved_64s[1]; /**< Reserved for future fields */
> > >       void *reserved_ptrs[2];   /**< Reserved for future fields */  
> >
> > Not sure you can claim ABI compatibility because the previous versions of DPDK
> > did not enforce that reserved fields must be zero.  The Linux kernel
> > learned this when adding flags for new system calls; reserved fields only
> > work if you enforce that application must set them to zero.  
> 
> In this case it rte_eth_dev_info is an out parameter and implementation of
> rte_eth_dev_info_get() already memseting to 0.
> Do you still see any other ABI issue?
> 
> See rte_eth_dev_info_get()
>         /*
>          * Init dev_info before port_id check since caller does not have
>          * return status and does not know if get is successful or not.
>          */
>         memset(dev_info, 0, sizeof(struct rte_eth_dev_info));

The concern was from the misreading comment.  It talks about what application should do.
Could you reword the comment so that it describes what pfc_queue_tc_max is here
and move the flow control set part of the comment to where the API for that is.

  reply	other threads:[~2021-12-05 18:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04 17:24 jerinj
2021-12-04 17:38 ` Stephen Hemminger
2021-12-05  7:03   ` Jerin Jacob
2021-12-05 18:00     ` Stephen Hemminger [this message]
2021-12-06  9:57       ` Jerin Jacob
2022-01-09 10:54 ` [PATCH v1 1/2] " skori
2022-01-09 10:54   ` [PATCH v1 2/2] app/testpmd: add queue based pfc CLI options skori
2022-01-09 10:58 ` [PATCH v1 1/2] ethdev: support queue-based priority flow control skori
2022-01-09 10:58   ` [PATCH v1 2/2] app/testpmd: add queue based pfc CLI options skori
2022-01-09 11:16   ` [PATCH v1 1/2] ethdev: support queue-based priority flow control Sunil Kumar Kori
2022-01-13 10:27   ` [dpdk-dev] [PATCH v2 " jerinj
2022-01-13 10:27     ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options jerinj
2022-01-25 17:36       ` Ferruh Yigit
2022-01-27  7:13         ` [EXT] " Sunil Kumar Kori
2022-01-27 10:40           ` Ferruh Yigit
2022-01-27 16:56             ` Ajit Khaparde
2022-01-31 13:03               ` Sunil Kumar Kori
2022-01-25 17:34     ` [dpdk-dev] [PATCH v2 1/2] ethdev: support queue-based priority flow control Ferruh Yigit
2022-01-25 18:52       ` Jerin Jacob
2022-01-31 18:08     ` [dpdk-dev] [PATCH v3 " jerinj
2022-01-31 18:08       ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add queue based pfc CLI options jerinj
2022-02-03 16:06         ` Ferruh Yigit
2022-02-03 17:19           ` [EXT] " Sunil Kumar Kori
2022-02-03 16:00       ` [dpdk-dev] [PATCH v3 1/2] ethdev: support queue-based priority flow control Ferruh Yigit
2022-02-07  7:23         ` Jerin Jacob
2022-02-07 13:55       ` [dpdk-dev] [PATCH v4 " jerinj
2022-02-07 13:55         ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add queue based pfc CLI options jerinj
2022-02-07 17:21           ` Ferruh Yigit
2022-02-07 17:27           ` Ajit Khaparde
2022-02-07 17:21         ` [dpdk-dev] [PATCH v4 1/2] ethdev: support queue-based priority flow control Ferruh Yigit
2022-02-08  6:05         ` Ajit Khaparde
2022-02-08  8:50         ` [dpdk-dev] [PATCH v5 " jerinj
2022-02-08  8:50           ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add queue based pfc CLI options jerinj
2022-02-08 13:07           ` [dpdk-dev] [PATCH v5 1/2] ethdev: support queue-based priority flow control Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211205100031.7be8e7b0@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=aboyer@pensando.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=asomalap@amd.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chas3@att.com \
    --cc=chenbo.xia@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=ed.czeck@atomicrules.com \
    --cc=evgenys@amazon.com \
    --cc=ferruh.yigit@intel.com \
    --cc=g.singh@nxp.com \
    --cc=grive@u256.net \
    --cc=haiyue.wang@intel.com \
    --cc=heinrich.kuhn@corigine.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=igorch@amazon.com \
    --cc=irusskikh@marvell.com \
    --cc=jasvinder.singh@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=jgrajcia@cisco.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=johndale@cisco.com \
    --cc=keith.wiles@intel.com \
    --cc=kirankumark@marvell.com \
    --cc=linville@tuxdriver.com \
    --cc=lironh@marvell.com \
    --cc=longli@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=matt.peters@windriver.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mdr@ashroe.eu \
    --cc=mk@semihalf.com \
    --cc=mtetsuyah@gmail.com \
    --cc=mw@semihalf.com \
    --cc=ndabilpuram@marvell.com \
    --cc=oulijun@huawei.com \
    --cc=pnalla@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=radhac@marvell.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=rmody@marvell.com \
    --cc=rosen.xu@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=shaibran@amazon.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=shshaikh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=spinler@cesnet.cz \
    --cc=steven.webster@windriver.com \
    --cc=sthemmin@microsoft.com \
    --cc=thomas@monjalon.net \
    --cc=vburru@marvell.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xuanziyang2@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=yongwang@vmware.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).