From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>,
david.marchand@redhat.com
Subject: Re: [PATCH] eal: remove unnecessary argv[0] handling
Date: Wed, 9 Feb 2022 11:29:49 -0800 [thread overview]
Message-ID: <20220209112949.7742991d@hermes.local> (raw)
In-Reply-To: <37375521.10thIPus4b@thomas>
On Wed, 09 Feb 2022 19:51:15 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 09/02/2022 16:45, Stephen Hemminger:
> > On Wed, 09 Feb 2022 15:58:26 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > > 02/02/2022 20:47, Stephen Hemminger:
> > > > The rte_eal_init function looks at argv[0] to determine
> > > > the program name to pass to the log init function.
> > > > This is both unnecessary and in a corner case a problem.
> > > >
> > > > Parsing argv[0] is unnecessary because the function openlog()
> > > > already determines the log identifier from program name if
> > > > NULL is passed, see openlog man page:
> > > > The string pointed to by ident is prepended to every message, and is
> > > > typically set to the program name. If ident is NULL, the program name
> > > > is used. (POSIX.1-2008 does not specify the behavior when ident is
> > > > NULL.)
> > >
> > > What about POSIX warning?
> > > Did you test it? Which libc? What about musl?
> >
> > Source for musl shows that openlog accepts NULL as ident.
> > It then generates log messages with ident in the message.
>
> In this case, it will be empty string.
> It seems this solution does not work with musl.
Good news: musl is available as debian package
Bad news: DPDK build is broken with musl
Library IPSec_MB found: YES
drivers/crypto/ipsec_mb/meson.build:19:4: ERROR: Could not get define 'IMB_VERSION_STR'
next prev parent reply other threads:[~2022-02-09 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 19:47 Stephen Hemminger
2022-02-09 14:58 ` Thomas Monjalon
2022-02-09 15:36 ` Stephen Hemminger
2022-02-09 15:45 ` Stephen Hemminger
2022-02-09 18:51 ` Thomas Monjalon
2022-02-09 19:29 ` Stephen Hemminger [this message]
2022-02-10 7:57 ` Thomas Monjalon
2022-02-09 15:54 ` [PATCH v2] Subject: " Stephen Hemminger
2022-02-09 20:41 ` [PATCH v3] eal: simplify " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209112949.7742991d@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).