DPDK patches and discussions
 help / color / mirror / Atom feed
From: Megha Ajmera <megha.ajmera@intel.com>
To: dev@dpdk.org, jasvinder.singh@intel.com,
	cristian.dumitrescu@intel.com, thomas@monjalon.net
Subject: [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config
Date: Fri, 18 Feb 2022 07:41:45 +0000	[thread overview]
Message-ID: <20220218074148.2549134-2-megha.ajmera@intel.com> (raw)
In-Reply-To: <20220218074148.2549134-1-megha.ajmera@intel.com>

Cleanup of sched config options those are by-default not defined.

Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 config/rte_config.h                        | 7 -------
 doc/guides/sample_app_ug/qos_scheduler.rst | 3 +--
 lib/sched/rte_sched.c                      | 4 ++++
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/config/rte_config.h b/config/rte_config.h
index cab4390a97..917097630e 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -88,13 +88,6 @@
 /* rte_power defines */
 #define RTE_MAX_LCORE_FREQS 64
 
-/* rte_sched defines */
-#undef RTE_SCHED_CMAN
-#undef RTE_SCHED_COLLECT_STATS
-#undef RTE_SCHED_SUBPORT_TC_OV
-#define RTE_SCHED_PORT_N_GRINDERS 8
-#undef RTE_SCHED_VECTOR
-
 /* KNI defines */
 #define RTE_KNI_PREEMPT_DEFAULT 1
 
diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst
index 49c14a00da..7016ca4078 100644
--- a/doc/guides/sample_app_ug/qos_scheduler.rst
+++ b/doc/guides/sample_app_ug/qos_scheduler.rst
@@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub-directory.
 .. note::
 
     To get statistics on the sample app using the command line interface as described in the next section,
-    DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which can be done by changing the relevant
-    entry in the ``config/rte_config.h`` file.
+    DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in the ``config/rte_config.h`` file.
 
 Running the Application
 -----------------------
diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
index 62b3d2e315..6c3e3bb0bf 100644
--- a/lib/sched/rte_sched.c
+++ b/lib/sched/rte_sched.c
@@ -35,6 +35,10 @@
 
 #endif
 
+#ifndef RTE_SCHED_PORT_N_GRINDERS
+#define RTE_SCHED_PORT_N_GRINDERS 8
+#endif
+
 #define RTE_SCHED_TB_RATE_CONFIG_ERR          (1e-7)
 #define RTE_SCHED_WRR_SHIFT                   3
 #define RTE_SCHED_MAX_QUEUES_PER_TC           RTE_SCHED_BE_QUEUES_PER_PIPE
-- 
2.25.1


  reply	other threads:[~2022-02-18  7:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  7:41 [PATCH v1 0/4] sched: HQoS Library cleanup Megha Ajmera
2022-02-18  7:41 ` Megha Ajmera [this message]
2022-02-18 16:23   ` [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config Stephen Hemminger
2022-02-18  7:41 ` [PATCH v1 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18  7:41 ` [PATCH v1 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18  7:41 ` [PATCH v1 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18  8:11 ` [PATCH v1 0/4] sched: HQoS Library cleanup David Marchand
2022-02-18  9:41   ` Ajmera, Megha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218074148.2549134-2-megha.ajmera@intel.com \
    --to=megha.ajmera@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).