From: Stephen Hemminger <stephen@networkplumber.org>
To: "usman.tanveer" <usman.tanveer@emumba.com>
Cc: reshma.pattan@intel.com, dev@dpdk.org
Subject: Re: [PATCH] app/pdump: close program if --pdump argument is missing
Date: Wed, 2 Mar 2022 08:52:25 -0800 [thread overview]
Message-ID: <20220302085225.117b8570@hermes.local> (raw)
In-Reply-To: <20220302092614.5164-1-usman.tanveer@emumba.com>
On Wed, 2 Mar 2022 14:26:14 +0500
"usman.tanveer" <usman.tanveer@emumba.com> wrote:
> --pdump is a mandatory argument in pdump application.
> It should print usage and exit if --pdump argument
> is missing. The application is not closing and getting
> stuck. Made the change to print usage and exit when
> this argument is missing.
>
> Signed-off-by: usman.tanveer <usman.tanveer@emumba.com>
Maybe pdump could just do something sane with no arguments.
That is one of the issues I tried to address by rewriting it.
Ideally, existing pdump can be deprecated and removed in 22.11?
next prev parent reply other threads:[~2022-03-02 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 9:26 usman.tanveer
2022-03-02 16:52 ` Stephen Hemminger [this message]
2022-03-31 12:59 ` Usman Tanveer
2023-07-01 2:16 ` [PATCH v2] app/pdump: exit if no device specified Stephen Hemminger
2023-07-03 6:29 ` fengchengwen
2023-07-06 10:45 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2022-03-02 9:20 [PATCH] app/pdump: close program if --pdump argument is missing usman.tanveer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302085225.117b8570@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=usman.tanveer@emumba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).