From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, fiona.trahe@intel.com
Subject: [PATCH 3/5] compressdev: fix missing space in header
Date: Fri, 11 Mar 2022 20:05:21 +0000 [thread overview]
Message-ID: <20220311200523.1020050-4-bruce.richardson@intel.com> (raw)
In-Reply-To: <20220311200523.1020050-1-bruce.richardson@intel.com>
Building with clang on FreeBSD with chkincs enabled, we get the
following error about a missing space:
../lib/compressdev/rte_compressdev_internal.h:25:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \
Adding in a space between the '"' and 'fmt' removes the error.
Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
Cc: fiona.trahe@intel.com
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/compressdev/rte_compressdev_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h
index 25d8afbfb9..b3b193e3ee 100644
--- a/lib/compressdev/rte_compressdev_internal.h
+++ b/lib/compressdev/rte_compressdev_internal.h
@@ -22,7 +22,7 @@ extern "C" {
/* Logging Macros */
extern int compressdev_logtype;
#define COMPRESSDEV_LOG(level, fmt, args...) \
- rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \
+ rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): " fmt "\n", \
__func__, ##args)
/**
--
2.34.1
next prev parent reply other threads:[~2022-03-11 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 20:05 [PATCH 0/5] build fixes on FreeBSD Bruce Richardson
2022-03-11 20:05 ` [PATCH 1/5] eal/freebsd: add missing C++ include guards Bruce Richardson
2022-03-11 20:05 ` [PATCH 2/5] compressdev: separate out driver-only headers Bruce Richardson
2022-03-11 20:05 ` Bruce Richardson [this message]
2022-03-11 20:05 ` [PATCH 4/5] cryptodev: fix compilation with clang C++ builds Bruce Richardson
2022-03-11 20:05 ` [PATCH 5/5] eventdev: " Bruce Richardson
2022-03-12 1:11 ` Stephen Hemminger
2022-03-14 9:00 ` Bruce Richardson
2022-03-15 1:13 ` [PATCH 0/5] build fixes on FreeBSD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311200523.1020050-4-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).