From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
pablo.de.lara.guarch@intel.com, declan.doherty@intel.com
Subject: [PATCH 4/5] cryptodev: fix compilation with clang C++ builds
Date: Fri, 11 Mar 2022 20:05:22 +0000 [thread overview]
Message-ID: <20220311200523.1020050-5-bruce.richardson@intel.com> (raw)
In-Reply-To: <20220311200523.1020050-1-bruce.richardson@intel.com>
When compiling on FreeBSD with clang and include checking enabled,
errors are emitted due to differences in how empty structs/unions are
handled in C and C++, as C++ structs cannot have zero size.
../lib/cryptodev/rte_crypto.h:127:2: error: union has size 0 in C, non-zero size in C++
Since the contents of the union are all themselves of zero size,
the actual union wrapper is unnecessary. We therefore remove it for C++
builds - though keep it for C builds for safety and clarity of
understanding the code.
Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")
Fixes: d2a4223c4c6d ("cryptodev: do not store pointer to op specific params")
Cc: pablo.de.lara.guarch@intel.com
Cc: declan.doherty@intel.com
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/cryptodev/rte_crypto.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h
index a864f5036f..aeb3bf6e38 100644
--- a/lib/cryptodev/rte_crypto.h
+++ b/lib/cryptodev/rte_crypto.h
@@ -123,15 +123,24 @@ struct rte_crypto_op {
rte_iova_t phys_addr;
/**< physical address of crypto operation */
+/* empty structures do not have zero size in C++ leading to compilation errors
+ * with clang about structure/union having different sizes in C and C++.
+ * While things are clearer with an explicit union, since each field is
+ * zero-sized it's not actually needed, so omit it for C++
+ */
+#ifndef __cplusplus
__extension__
union {
+#endif
struct rte_crypto_sym_op sym[0];
/**< Symmetric operation parameters */
struct rte_crypto_asym_op asym[0];
/**< Asymmetric operation parameters */
+#ifndef __cplusplus
}; /**< operation specific parameters */
+#endif
};
/**
--
2.34.1
next prev parent reply other threads:[~2022-03-11 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 20:05 [PATCH 0/5] build fixes on FreeBSD Bruce Richardson
2022-03-11 20:05 ` [PATCH 1/5] eal/freebsd: add missing C++ include guards Bruce Richardson
2022-03-11 20:05 ` [PATCH 2/5] compressdev: separate out driver-only headers Bruce Richardson
2022-03-11 20:05 ` [PATCH 3/5] compressdev: fix missing space in header Bruce Richardson
2022-03-11 20:05 ` Bruce Richardson [this message]
2022-03-11 20:05 ` [PATCH 5/5] eventdev: fix compilation with clang C++ builds Bruce Richardson
2022-03-12 1:11 ` Stephen Hemminger
2022-03-14 9:00 ` Bruce Richardson
2022-03-15 1:13 ` [PATCH 0/5] build fixes on FreeBSD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311200523.1020050-5-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).