From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack
Date: Thu, 17 Mar 2022 16:13:25 -0700 [thread overview]
Message-ID: <20220317161325.3c4cc14a@hermes.local> (raw)
In-Reply-To: <9139565.2WqB4rESCP@thomas>
On Sun, 13 Feb 2022 12:41:59 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 12/02/2022 19:44, Stephen Hemminger:
> > The glibc backtrace_symbols() calls malloc which makes it
> > dangerous to use rte_dump_stack() in a signal handler that
> > is handling errors that maybe due to memory corruption.
> >
> > Instead, use dladdr() to lookup up symbols incrementally.
> >
> > The format of the messages is based on what X org server
> > has been doing for many years. It changes from bottom up
> > to top down order.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Morten acked the RFC.
> Is there any significant change?
>
>
>
The change was making it not RFC.
Lets make a common code for this FreeBSD should have same code.
next prev parent reply other threads:[~2022-03-17 23:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 1:10 [RFC] " Stephen Hemminger
2022-01-29 8:25 ` Morten Brørup
2022-02-12 18:44 ` [PATCH v2 0/2] rte_dump_stack: improvements Stephen Hemminger
2022-02-12 18:44 ` [PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack Stephen Hemminger
2022-02-13 11:41 ` Thomas Monjalon
2022-03-17 23:13 ` Stephen Hemminger [this message]
2022-02-12 18:44 ` [PATCH v2 2/2] eal: common rte_dump_stack for both Linux and FreeBSD Stephen Hemminger
2022-02-14 11:10 ` [PATCH v2 0/2] rte_dump_stack: improvements Morten Brørup
2022-02-14 11:51 ` Bruce Richardson
2022-04-07 12:45 ` David Marchand
2022-04-07 23:06 ` Stephen Hemminger
2022-04-14 19:41 ` [PATCH v3] rte_dump_stack: make in async signal safe Stephen Hemminger
2022-04-14 20:19 ` [PATCH v4] " Stephen Hemminger
2022-06-23 7:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317161325.3c4cc14a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).