From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: [PATCH] eal: factorize lcore main loop
Date: Wed, 23 Mar 2022 10:30:01 +0100 [thread overview]
Message-ID: <20220323093001.20618-1-david.marchand@redhat.com> (raw)
All OS implementations provide the same main loop.
Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation
between main and threads and factorize the rest as common code.
Thread id are now logged as string in a common format across OS.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
I had this patch in store for a long time.
I don't particularly care about it, it's not fixing anything.
But it seems a good cleanup/consolidation, so I rebased it and I am
sending it to get feedback.
---
lib/eal/common/eal_common_launch.c | 36 +++++++-
lib/eal/common/eal_common_thread.c | 72 +++++++++++++++
lib/eal/common/eal_thread.h | 27 ++++++
lib/eal/freebsd/eal.c | 7 +-
lib/eal/freebsd/eal_thread.c | 138 ----------------------------
lib/eal/linux/eal.c | 4 +-
lib/eal/linux/eal_thread.c | 139 +----------------------------
lib/eal/unix/eal_unix_thread.c | 63 +++++++++++++
lib/eal/unix/meson.build | 5 +-
lib/eal/windows/eal_thread.c | 137 +++++++---------------------
10 files changed, 236 insertions(+), 392 deletions(-)
create mode 100644 lib/eal/unix/eal_unix_thread.c
diff --git a/lib/eal/common/eal_common_launch.c b/lib/eal/common/eal_common_launch.c
index 9f393b9bda..5770803172 100644
--- a/lib/eal/common/eal_common_launch.c
+++ b/lib/eal/common/eal_common_launch.c
@@ -5,11 +5,13 @@
#include <errno.h>
#include <rte_launch.h>
+#include <rte_eal_trace.h>
#include <rte_atomic.h>
#include <rte_pause.h>
#include <rte_lcore.h>
#include "eal_private.h"
+#include "eal_thread.h"
/*
* Wait until a lcore finished its job.
@@ -18,12 +20,44 @@ int
rte_eal_wait_lcore(unsigned worker_id)
{
while (__atomic_load_n(&lcore_config[worker_id].state,
- __ATOMIC_ACQUIRE) != WAIT)
+ __ATOMIC_ACQUIRE) != WAIT)
rte_pause();
return lcore_config[worker_id].ret;
}
+/*
+ * Send a message to a worker lcore identified by worker_id to call a
+ * function f with argument arg. Once the execution is done, the
+ * remote lcore switches to WAIT state.
+ */
+int
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned int worker_id)
+{
+ int rc = -EBUSY;
+
+ /* Check if the worker is in 'WAIT' state. Use acquire order
+ * since 'state' variable is used as the guard variable.
+ */
+ if (__atomic_load_n(&lcore_config[worker_id].state,
+ __ATOMIC_ACQUIRE) != WAIT)
+ goto finish;
+
+ lcore_config[worker_id].arg = arg;
+ /* Ensure that all the memory operations are completed
+ * before the worker thread starts running the function.
+ * Use worker thread function as the guard variable.
+ */
+ __atomic_store_n(&lcore_config[worker_id].f, f, __ATOMIC_RELEASE);
+
+ eal_thread_wake_worker(worker_id);
+ rc = 0;
+
+finish:
+ rte_eal_trace_thread_remote_launch(f, arg, worker_id, rc);
+ return rc;
+}
+
/*
* Check that every WORKER lcores are in WAIT state, then call
* rte_eal_remote_launch() for all of them. If call_main is true
diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c
index 684bea166c..256de91abc 100644
--- a/lib/eal/common/eal_common_thread.c
+++ b/lib/eal/common/eal_common_thread.c
@@ -9,6 +9,7 @@
#include <assert.h>
#include <string.h>
+#include <rte_eal_trace.h>
#include <rte_errno.h>
#include <rte_lcore.h>
#include <rte_log.h>
@@ -163,6 +164,77 @@ __rte_thread_uninit(void)
RTE_PER_LCORE(_lcore_id) = LCORE_ID_ANY;
}
+/* main loop of threads */
+__rte_noreturn void *
+eal_thread_loop(__rte_unused void *arg)
+{
+ char cpuset[RTE_CPU_AFFINITY_STR_LEN];
+ pthread_t thread_id = pthread_self();
+ unsigned int lcore_id;
+ int ret;
+
+ /* retrieve our lcore_id from the configuration structure */
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ if (thread_id == lcore_config[lcore_id].thread_id)
+ break;
+ }
+ if (lcore_id == RTE_MAX_LCORE)
+ rte_panic("cannot retrieve lcore id\n");
+
+ __rte_thread_init(lcore_id, &lcore_config[lcore_id].cpuset);
+
+ ret = eal_thread_dump_current_affinity(cpuset, sizeof(cpuset));
+ RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%zx;cpuset=[%s%s])\n",
+ lcore_id, (uintptr_t)thread_id, cpuset,
+ ret == 0 ? "" : "...");
+
+ rte_eal_trace_thread_lcore_ready(lcore_id, cpuset);
+
+ /* read on our pipe to get commands */
+ while (1) {
+ lcore_function_t *f;
+ void *fct_arg;
+
+ eal_thread_wait_command();
+
+ /* Set the state to 'RUNNING'. Use release order
+ * since 'state' variable is used as the guard variable.
+ */
+ __atomic_store_n(&lcore_config[lcore_id].state, RUNNING,
+ __ATOMIC_RELEASE);
+
+ eal_thread_ack_command();
+
+ /* Load 'f' with acquire order to ensure that
+ * the memory operations from the main thread
+ * are accessed only after update to 'f' is visible.
+ * Wait till the update to 'f' is visible to the worker.
+ */
+ while ((f = __atomic_load_n(&lcore_config[lcore_id].f,
+ __ATOMIC_ACQUIRE)) == NULL)
+ rte_pause();
+
+ /* call the function and store the return value */
+ fct_arg = lcore_config[lcore_id].arg;
+ ret = f(fct_arg);
+ lcore_config[lcore_id].ret = ret;
+ lcore_config[lcore_id].f = NULL;
+ lcore_config[lcore_id].arg = NULL;
+
+ /* Store the state with release order to ensure that
+ * the memory operations from the worker thread
+ * are completed before the state is updated.
+ * Use 'state' as the guard variable.
+ */
+ __atomic_store_n(&lcore_config[lcore_id].state, WAIT,
+ __ATOMIC_RELEASE);
+ }
+
+ /* never reached */
+ /* pthread_exit(NULL); */
+ /* return NULL; */
+}
+
enum __rte_ctrl_thread_status {
CTRL_THREAD_LAUNCHING, /* Yet to call pthread_create function */
CTRL_THREAD_RUNNING, /* Control thread is running successfully */
diff --git a/lib/eal/common/eal_thread.h b/lib/eal/common/eal_thread.h
index 4a49117be8..b08dcf34b5 100644
--- a/lib/eal/common/eal_thread.h
+++ b/lib/eal/common/eal_thread.h
@@ -58,4 +58,31 @@ eal_thread_dump_affinity(rte_cpuset_t *cpuset, char *str, unsigned int size);
int
eal_thread_dump_current_affinity(char *str, unsigned int size);
+/**
+ * Called by the main thread to wake up a worker in 'WAIT' state.
+ * This function blocks until the worker acknowledge it started processing a
+ * new command.
+ * This function is private to EAL.
+ *
+ * @param worker_id
+ * The lcore_id of a worker thread.
+ */
+void
+eal_thread_wake_worker(unsigned int worker_id);
+
+/**
+ * Called by a worker thread to sleep after entering 'WAIT' state.
+ * This function is private to EAL.
+ */
+void
+eal_thread_wait_command(void);
+
+/**
+ * Called by a worker thread to acknowledge new command after leaving 'WAIT'
+ * state.
+ * This function is private to EAL.
+ */
+void
+eal_thread_ack_command(void);
+
#endif /* EAL_THREAD_H */
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 71993fe25b..80bc3d25e0 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -579,7 +579,6 @@ int
rte_eal_init(int argc, char **argv)
{
int i, fctret, ret;
- pthread_t thread_id;
static uint32_t run_once;
uint32_t has_run = 0;
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
@@ -604,8 +603,6 @@ rte_eal_init(int argc, char **argv)
return -1;
}
- thread_id = pthread_self();
-
eal_reset_internal_config(internal_conf);
/* clone argv to report out later in telemetry */
@@ -794,8 +791,8 @@ rte_eal_init(int argc, char **argv)
ret = eal_thread_dump_current_affinity(cpuset, sizeof(cpuset));
- RTE_LOG(DEBUG, EAL, "Main lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
- config->main_lcore, thread_id, cpuset,
+ RTE_LOG(DEBUG, EAL, "Main lcore %u is ready (tid=%zx;cpuset=[%s%s])\n",
+ config->main_lcore, (uintptr_t)pthread_self(), cpuset,
ret == 0 ? "" : "...");
RTE_LCORE_FOREACH_WORKER(i) {
diff --git a/lib/eal/freebsd/eal_thread.c b/lib/eal/freebsd/eal_thread.c
index 3b18030d73..ab81b527bc 100644
--- a/lib/eal/freebsd/eal_thread.c
+++ b/lib/eal/freebsd/eal_thread.c
@@ -20,148 +20,10 @@
#include <rte_per_lcore.h>
#include <rte_eal.h>
#include <rte_lcore.h>
-#include <rte_eal_trace.h>
#include "eal_private.h"
#include "eal_thread.h"
-/*
- * Send a message to a worker lcore identified by worker_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switches to WAIT state.
- */
-int
-rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)
-{
- int n;
- char c = 0;
- int m2w = lcore_config[worker_id].pipe_main2worker[1];
- int w2m = lcore_config[worker_id].pipe_worker2main[0];
- int rc = -EBUSY;
-
- /* Check if the worker is in 'WAIT' state. Use acquire order
- * since 'state' variable is used as the guard variable.
- */
- if (__atomic_load_n(&lcore_config[worker_id].state,
- __ATOMIC_ACQUIRE) != WAIT)
- goto finish;
-
- lcore_config[worker_id].arg = arg;
- /* Ensure that all the memory operations are completed
- * before the worker thread starts running the function.
- * Use worker thread function as the guard variable.
- */
- __atomic_store_n(&lcore_config[worker_id].f, f, __ATOMIC_RELEASE);
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(m2w, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* wait ack */
- do {
- n = read(w2m, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- rc = 0;
-finish:
- rte_eal_trace_thread_remote_launch(f, arg, worker_id, rc);
- return rc;
-}
-
-/* main loop of threads */
-__rte_noreturn void *
-eal_thread_loop(__rte_unused void *arg)
-{
- char c;
- int n, ret;
- unsigned lcore_id;
- pthread_t thread_id;
- int m2w, w2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_WORKER(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
-
- m2w = lcore_config[lcore_id].pipe_main2worker[0];
- w2m = lcore_config[lcore_id].pipe_worker2main[1];
-
- __rte_thread_init(lcore_id, &lcore_config[lcore_id].cpuset);
-
- ret = eal_thread_dump_current_affinity(cpuset, sizeof(cpuset));
- RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
- lcore_id, thread_id, cpuset, ret == 0 ? "" : "...");
-
- rte_eal_trace_thread_lcore_ready(lcore_id, cpuset);
-
- /* read on our pipe to get commands */
- while (1) {
- lcore_function_t *f;
- void *fct_arg;
-
- /* wait command */
- do {
- n = read(m2w, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- /* Set the state to 'RUNNING'. Use release order
- * since 'state' variable is used as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, RUNNING,
- __ATOMIC_RELEASE);
-
- /* send ack */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(w2m, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* Load 'f' with acquire order to ensure that
- * the memory operations from the main thread
- * are accessed only after update to 'f' is visible.
- * Wait till the update to 'f' is visible to the worker.
- */
- while ((f = __atomic_load_n(&lcore_config[lcore_id].f,
- __ATOMIC_ACQUIRE)) == NULL)
- rte_pause();
-
- /* call the function and store the return value */
- fct_arg = lcore_config[lcore_id].arg;
- ret = f(fct_arg);
- lcore_config[lcore_id].ret = ret;
- lcore_config[lcore_id].f = NULL;
- lcore_config[lcore_id].arg = NULL;
-
- /* Store the state with release order to ensure that
- * the memory operations from the worker thread
- * are completed before the state is updated.
- * Use 'state' as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, WAIT,
- __ATOMIC_RELEASE);
- }
-
- /* never reached */
- /* pthread_exit(NULL); */
- /* return NULL; */
-}
-
/* require calling thread tid by gettid() */
int rte_sys_gettid(void)
{
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 025e5cc10d..8a405d1d59 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -862,7 +862,6 @@ int
rte_eal_init(int argc, char **argv)
{
int i, fctret, ret;
- pthread_t thread_id;
static uint32_t run_once;
uint32_t has_run = 0;
const char *p;
@@ -890,7 +889,6 @@ rte_eal_init(int argc, char **argv)
p = strrchr(argv[0], '/');
strlcpy(logid, p ? p + 1 : argv[0], sizeof(logid));
- thread_id = pthread_self();
eal_reset_internal_config(internal_conf);
@@ -1129,7 +1127,7 @@ rte_eal_init(int argc, char **argv)
ret = eal_thread_dump_current_affinity(cpuset, sizeof(cpuset));
RTE_LOG(DEBUG, EAL, "Main lcore %u is ready (tid=%zx;cpuset=[%s%s])\n",
- config->main_lcore, (uintptr_t)thread_id, cpuset,
+ config->main_lcore, (uintptr_t)pthread_self(), cpuset,
ret == 0 ? "" : "...");
RTE_LCORE_FOREACH_WORKER(i) {
diff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c
index fa6cd7e2c4..820cc905e0 100644
--- a/lib/eal/linux/eal_thread.c
+++ b/lib/eal/linux/eal_thread.c
@@ -14,148 +14,11 @@
#include <rte_log.h>
#include <rte_eal.h>
#include <rte_lcore.h>
-#include <rte_eal_trace.h>
+#include <rte_string_fns.h>
#include "eal_private.h"
#include "eal_thread.h"
-/*
- * Send a message to a worker lcore identified by worker_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switches to WAIT state.
- */
-int
-rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned int worker_id)
-{
- int n;
- char c = 0;
- int m2w = lcore_config[worker_id].pipe_main2worker[1];
- int w2m = lcore_config[worker_id].pipe_worker2main[0];
- int rc = -EBUSY;
-
- /* Check if the worker is in 'WAIT' state. Use acquire order
- * since 'state' variable is used as the guard variable.
- */
- if (__atomic_load_n(&lcore_config[worker_id].state,
- __ATOMIC_ACQUIRE) != WAIT)
- goto finish;
-
- lcore_config[worker_id].arg = arg;
- /* Ensure that all the memory operations are completed
- * before the worker thread starts running the function.
- * Use worker thread function pointer as the guard variable.
- */
- __atomic_store_n(&lcore_config[worker_id].f, f, __ATOMIC_RELEASE);
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(m2w, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* wait ack */
- do {
- n = read(w2m, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- rc = 0;
-finish:
- rte_eal_trace_thread_remote_launch(f, arg, worker_id, rc);
- return rc;
-}
-
-/* main loop of threads */
-__rte_noreturn void *
-eal_thread_loop(__rte_unused void *arg)
-{
- char c;
- int n, ret;
- unsigned lcore_id;
- pthread_t thread_id;
- int m2w, w2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_WORKER(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
-
- m2w = lcore_config[lcore_id].pipe_main2worker[0];
- w2m = lcore_config[lcore_id].pipe_worker2main[1];
-
- __rte_thread_init(lcore_id, &lcore_config[lcore_id].cpuset);
-
- ret = eal_thread_dump_current_affinity(cpuset, sizeof(cpuset));
- RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%zx;cpuset=[%s%s])\n",
- lcore_id, (uintptr_t)thread_id, cpuset, ret == 0 ? "" : "...");
-
- rte_eal_trace_thread_lcore_ready(lcore_id, cpuset);
-
- /* read on our pipe to get commands */
- while (1) {
- lcore_function_t *f;
- void *fct_arg;
-
- /* wait command */
- do {
- n = read(m2w, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- /* Set the state to 'RUNNING'. Use release order
- * since 'state' variable is used as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, RUNNING,
- __ATOMIC_RELEASE);
-
- /* send ack */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(w2m, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* Load 'f' with acquire order to ensure that
- * the memory operations from the main thread
- * are accessed only after update to 'f' is visible.
- * Wait till the update to 'f' is visible to the worker.
- */
- while ((f = __atomic_load_n(&lcore_config[lcore_id].f,
- __ATOMIC_ACQUIRE)) == NULL)
- rte_pause();
-
- /* call the function and store the return value */
- fct_arg = lcore_config[lcore_id].arg;
- ret = f(fct_arg);
- lcore_config[lcore_id].ret = ret;
- lcore_config[lcore_id].f = NULL;
- lcore_config[lcore_id].arg = NULL;
-
- /* Store the state with release order to ensure that
- * the memory operations from the worker thread
- * are completed before the state is updated.
- * Use 'state' as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, WAIT,
- __ATOMIC_RELEASE);
- }
-
- /* never reached */
- /* pthread_exit(NULL); */
- /* return NULL; */
-}
-
/* require calling thread tid by gettid() */
int rte_sys_gettid(void)
{
diff --git a/lib/eal/unix/eal_unix_thread.c b/lib/eal/unix/eal_unix_thread.c
new file mode 100644
index 0000000000..70b5ba6b98
--- /dev/null
+++ b/lib/eal/unix/eal_unix_thread.c
@@ -0,0 +1,63 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2022 Red Hat, Inc.
+ */
+
+#include <errno.h>
+#include <unistd.h>
+
+#include <rte_debug.h>
+
+#include "eal_private.h"
+
+void
+eal_thread_wake_worker(unsigned int worker_id)
+{
+ int m2w = lcore_config[worker_id].pipe_main2worker[1];
+ int w2m = lcore_config[worker_id].pipe_worker2main[0];
+ char c = 0;
+ int n;
+
+ do {
+ n = write(m2w, &c, 1);
+ } while (n == 0 || (n < 0 && errno == EINTR));
+ if (n < 0)
+ rte_panic("cannot write on configuration pipe\n");
+
+ do {
+ n = read(w2m, &c, 1);
+ } while (n < 0 && errno == EINTR);
+ if (n <= 0)
+ rte_panic("cannot read on configuration pipe\n");
+}
+
+void
+eal_thread_wait_command(void)
+{
+ unsigned int lcore_id = rte_lcore_id();
+ int m2w;
+ char c;
+ int n;
+
+ m2w = lcore_config[lcore_id].pipe_main2worker[0];
+ do {
+ n = read(m2w, &c, 1);
+ } while (n < 0 && errno == EINTR);
+ if (n <= 0)
+ rte_panic("cannot read on configuration pipe\n");
+}
+
+void
+eal_thread_ack_command(void)
+{
+ unsigned int lcore_id = rte_lcore_id();
+ char c = 0;
+ int w2m;
+ int n;
+
+ w2m = lcore_config[lcore_id].pipe_worker2main[1];
+ do {
+ n = write(w2m, &c, 1);
+ } while (n == 0 || (n < 0 && errno == EINTR));
+ if (n < 0)
+ rte_panic("cannot write on configuration pipe\n");
+}
diff --git a/lib/eal/unix/meson.build b/lib/eal/unix/meson.build
index a22ea7cabc..781505ca90 100644
--- a/lib/eal/unix/meson.build
+++ b/lib/eal/unix/meson.build
@@ -3,9 +3,10 @@
sources += files(
'eal_file.c',
+ 'eal_filesystem.c',
+ 'eal_firmware.c',
'eal_unix_memory.c',
+ 'eal_unix_thread.c',
'eal_unix_timer.c',
- 'eal_firmware.c',
- 'eal_filesystem.c',
'rte_thread.c',
)
diff --git a/lib/eal/windows/eal_thread.c b/lib/eal/windows/eal_thread.c
index 54fa93fa62..de1c0078a5 100644
--- a/lib/eal/windows/eal_thread.c
+++ b/lib/eal/windows/eal_thread.c
@@ -11,135 +11,62 @@
#include <rte_per_lcore.h>
#include <rte_common.h>
#include <rte_memory.h>
-#include <eal_thread.h>
#include "eal_private.h"
+#include "eal_thread.h"
#include "eal_windows.h"
-/*
- * Send a message to a worker lcore identified by worker_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switches to WAIT state.
- */
-int
-rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned int worker_id)
+void
+eal_thread_wake_worker(unsigned int worker_id)
{
- int n;
- char c = 0;
int m2w = lcore_config[worker_id].pipe_main2worker[1];
int w2m = lcore_config[worker_id].pipe_worker2main[0];
+ char c = 0;
+ int n;
- /* Check if the worker is in 'WAIT' state. Use acquire order
- * since 'state' variable is used as the guard variable.
- */
- if (__atomic_load_n(&lcore_config[worker_id].state,
- __ATOMIC_ACQUIRE) != WAIT)
- return -EBUSY;
-
- lcore_config[worker_id].arg = arg;
- /* Ensure that all the memory operations are completed
- * before the worker thread starts running the function.
- * Use worker thread function as the guard variable.
- */
- __atomic_store_n(&lcore_config[worker_id].f, f, __ATOMIC_RELEASE);
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
+ do {
n = _write(m2w, &c, 1);
+ } while (n == 0 || (n < 0 && errno == EINTR));
if (n < 0)
rte_panic("cannot write on configuration pipe\n");
- /* wait ack */
do {
n = _read(w2m, &c, 1);
} while (n < 0 && errno == EINTR);
-
if (n <= 0)
rte_panic("cannot read on configuration pipe\n");
-
- return 0;
}
-/* main loop of threads */
-void *
-eal_thread_loop(void *arg __rte_unused)
+void
+eal_thread_wait_command(void)
{
+ unsigned int lcore_id = rte_lcore_id();
+ int m2w;
char c;
- int n, ret;
- unsigned int lcore_id;
- pthread_t thread_id;
- int m2w, w2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_WORKER(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
+ int n;
m2w = lcore_config[lcore_id].pipe_main2worker[0];
- w2m = lcore_config[lcore_id].pipe_worker2main[1];
+ do {
+ n = _read(m2w, &c, 1);
+ } while (n < 0 && errno == EINTR);
+ if (n <= 0)
+ rte_panic("cannot read on configuration pipe\n");
+}
+
+void
+eal_thread_ack_command(void)
+{
+ unsigned int lcore_id = rte_lcore_id();
+ char c = 0;
+ int w2m;
+ int n;
- __rte_thread_init(lcore_id, &lcore_config[lcore_id].cpuset);
-
- RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%zx;cpuset=[%s])\n",
- lcore_id, (uintptr_t)thread_id, cpuset);
-
- /* read on our pipe to get commands */
- while (1) {
- lcore_function_t *f;
- void *fct_arg;
-
- /* wait command */
- do {
- n = _read(m2w, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- /* Set the state to 'RUNNING'. Use release order
- * since 'state' variable is used as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, RUNNING,
- __ATOMIC_RELEASE);
-
- /* send ack */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = _write(w2m, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* Load 'f' with acquire order to ensure that
- * the memory operations from the main thread
- * are accessed only after update to 'f' is visible.
- * Wait till the update to 'f' is visible to the worker.
- */
- while ((f = __atomic_load_n(&lcore_config[lcore_id].f,
- __ATOMIC_ACQUIRE)) == NULL)
- rte_pause();
-
- /* call the function and store the return value */
- fct_arg = lcore_config[lcore_id].arg;
- ret = f(fct_arg);
- lcore_config[lcore_id].ret = ret;
- lcore_config[lcore_id].f = NULL;
- lcore_config[lcore_id].arg = NULL;
-
- /* Store the state with release order to ensure that
- * the memory operations from the worker thread
- * are completed before the state is updated.
- * Use 'state' as the guard variable.
- */
- __atomic_store_n(&lcore_config[lcore_id].state, WAIT,
- __ATOMIC_RELEASE);
- }
+ w2m = lcore_config[lcore_id].pipe_worker2main[1];
+ do {
+ n = _write(w2m, &c, 1);
+ } while (n == 0 || (n < 0 && errno == EINTR));
+ if (n < 0)
+ rte_panic("cannot write on configuration pipe\n");
}
/* function to create threads */
--
2.23.0
next reply other threads:[~2022-03-23 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:30 David Marchand [this message]
2022-03-23 12:01 ` Morten Brørup
2022-03-24 8:31 ` Tyler Retzlaff
2022-03-24 14:44 ` David Marchand
2022-03-25 12:11 ` Tyler Retzlaff
2022-03-25 14:58 ` Thomas Monjalon
2022-03-25 15:09 ` David Marchand
2022-03-25 16:38 ` Tyler Retzlaff
2022-03-25 12:23 ` Tyler Retzlaff
2022-04-01 8:44 ` [PATCH v2 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-01 8:44 ` [PATCH v2 2/2] eal: factorize lcore main loop David Marchand
2022-04-05 7:05 ` David Marchand
2022-04-05 16:34 ` [PATCH v3 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-05 16:34 ` [PATCH v3 2/2] eal: factorize lcore main loop David Marchand
2022-04-14 11:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323093001.20618-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).