From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Morten Brørup" <mb@smartsharesystems.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>
Subject: Re: [PATCH v2 0/2] rte_dump_stack: improvements
Date: Thu, 7 Apr 2022 16:06:23 -0700 [thread overview]
Message-ID: <20220407160623.77e9d5a6@hermes.local> (raw)
In-Reply-To: <CAJFAV8yk5VcvPzjRo2aGJXM_oTdpjpG5fF6HKjmX_aGHnNG2Bw@mail.gmail.com>
On Thu, 7 Apr 2022 14:45:07 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Sat, Feb 12, 2022 at 7:44 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > This is update to earlier RFC. Add some more comments and changes
> > to have common code for Linux and FreeBSD
> >
> > Stephen Hemminger (2):
> > eal_debug: do not use malloc in rte_dump_stack
> > eal: common rte_dump_stack for both Linux and FreeBSD
> >
> > lib/eal/freebsd/eal_debug.c | 43 ------------------------
> > lib/eal/freebsd/meson.build | 1 -
> > lib/eal/linux/eal_debug.c | 43 ------------------------
> > lib/eal/linux/meson.build | 1 -
> > lib/eal/unix/eal_debug.c | 65 +++++++++++++++++++++++++++++++++++++
> > lib/eal/unix/meson.build | 5 +--
> > 6 files changed, 68 insertions(+), 90 deletions(-)
> > delete mode 100644 lib/eal/freebsd/eal_debug.c
> > delete mode 100644 lib/eal/linux/eal_debug.c
> > create mode 100644 lib/eal/unix/eal_debug.c
>
> Strange to change only the Linux implementation as a first patch, then
> merge implementations in a second time effectively changing FreeBSD
> implementation in what is presented in commitlog as a factorisation
> cleanup.
> Please invert the patches.
>
> Besides, the series does not compile on current main.
> It's probably a result of the header inclusion cleanup we had in
> v22.03, but I prefer you check.
>
>
> Thanks.
As I looked at it more, there was more there.
Turns out that printf and therefore rte_log() is not signal safe.
There is a version of backtrace_symbols_fd that just uses writev() on glibc for Linux
so that is a better alternative, but format changes.
But the BSD version of backtrace_symbols_fd uses printf and is therefore not signal safe.
Not sure if that matters.
next prev parent reply other threads:[~2022-04-07 23:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 1:10 [RFC] eal_debug: do not use malloc in rte_dump_stack Stephen Hemminger
2022-01-29 8:25 ` Morten Brørup
2022-02-12 18:44 ` [PATCH v2 0/2] rte_dump_stack: improvements Stephen Hemminger
2022-02-12 18:44 ` [PATCH v2 1/2] eal_debug: do not use malloc in rte_dump_stack Stephen Hemminger
2022-02-13 11:41 ` Thomas Monjalon
2022-03-17 23:13 ` Stephen Hemminger
2022-02-12 18:44 ` [PATCH v2 2/2] eal: common rte_dump_stack for both Linux and FreeBSD Stephen Hemminger
2022-02-14 11:10 ` [PATCH v2 0/2] rte_dump_stack: improvements Morten Brørup
2022-02-14 11:51 ` Bruce Richardson
2022-04-07 12:45 ` David Marchand
2022-04-07 23:06 ` Stephen Hemminger [this message]
2022-04-14 19:41 ` [PATCH v3] rte_dump_stack: make in async signal safe Stephen Hemminger
2022-04-14 20:19 ` [PATCH v4] " Stephen Hemminger
2022-06-23 7:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407160623.77e9d5a6@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).