DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
	Hernan <hernan.vargas@intel.com>
Subject: [PATCH v2 1/5] baseband/fpga_5gnr_fec: remove FLR timeout
Date: Thu, 19 May 2022 22:05:52 -0500	[thread overview]
Message-ID: <20220520030556.3475133-2-hernan.vargas@intel.com> (raw)
In-Reply-To: <20220520030556.3475133-1-hernan.vargas@intel.com>

From: Hernan <hernan.vargas@intel.com>

FLR timeout register is not used in 5GNR FPGA.

Signed-off-by: Hernan <hernan.vargas@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c                       | 4 ----
 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h         | 2 --
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c     | 9 ---------
 drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 2 --
 4 files changed, 17 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 0fa119a502..fad3b1e49d 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -50,7 +50,6 @@
 #define DL_5G_BANDWIDTH 3
 #define UL_5G_LOAD_BALANCE 128
 #define DL_5G_LOAD_BALANCE 128
-#define FLR_5G_TIMEOUT 610
 #endif
 
 #ifdef RTE_BASEBAND_ACC100
@@ -699,9 +698,6 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
 		conf.ul_load_balance = UL_5G_LOAD_BALANCE;
 		conf.dl_load_balance = DL_5G_LOAD_BALANCE;
 
-		/**< FLR timeout value */
-		conf.flr_time_out = FLR_5G_TIMEOUT;
-
 		/* setup FPGA PF with configuration information */
 		ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf);
 		TEST_ASSERT_SUCCESS(ret,
diff --git a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
index e72c95e936..ed8ce26eaa 100644
--- a/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
+++ b/drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h
@@ -36,7 +36,6 @@
 #define FPGA_RING_DESC_LEN_UNIT_BYTES (32)
 /* Maximum size of queue */
 #define FPGA_RING_MAX_SIZE (1024)
-#define FPGA_FLR_TIMEOUT_UNIT (16.384)
 
 #define FPGA_NUM_UL_QUEUES (32)
 #define FPGA_NUM_DL_QUEUES (32)
@@ -70,7 +69,6 @@ enum {
 	FPGA_5GNR_FEC_QUEUE_PF_VF_MAP_DONE = 0x00000008, /* len: 1B */
 	FPGA_5GNR_FEC_LOAD_BALANCE_FACTOR = 0x0000000a, /* len: 2B */
 	FPGA_5GNR_FEC_RING_DESC_LEN = 0x0000000c, /* len: 2B */
-	FPGA_5GNR_FEC_FLR_TIME_OUT = 0x0000000e, /* len: 2B */
 	FPGA_5GNR_FEC_VFQ_FLUSH_STATUS_LW = 0x00000018, /* len: 4B */
 	FPGA_5GNR_FEC_VFQ_FLUSH_STATUS_HI = 0x0000001c, /* len: 4B */
 	FPGA_5GNR_FEC_QUEUE_MAP = 0x00000040, /* len: 256B */
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 15d23d6269..6737b74901 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -83,8 +83,6 @@ print_static_reg_debug_info(void *mmio_base)
 			FPGA_5GNR_FEC_LOAD_BALANCE_FACTOR);
 	uint16_t ring_desc_len = fpga_reg_read_16(mmio_base,
 			FPGA_5GNR_FEC_RING_DESC_LEN);
-	uint16_t flr_time_out = fpga_reg_read_16(mmio_base,
-			FPGA_5GNR_FEC_FLR_TIME_OUT);
 
 	rte_bbdev_log_debug("UL.DL Weights = %u.%u",
 			((uint8_t)config), ((uint8_t)(config >> 8)));
@@ -94,8 +92,6 @@ print_static_reg_debug_info(void *mmio_base)
 			(qmap_done > 0) ? "READY" : "NOT-READY");
 	rte_bbdev_log_debug("Ring Descriptor Size = %u bytes",
 			ring_desc_len*FPGA_RING_DESC_LEN_UNIT_BYTES);
-	rte_bbdev_log_debug("FLR Timeout = %f usec",
-			(float)flr_time_out*FPGA_FLR_TIMEOUT_UNIT);
 }
 
 /* Print decode DMA Descriptor of FPGA 5GNR Decoder device */
@@ -2120,11 +2116,6 @@ rte_fpga_5gnr_fec_configure(const char *dev_name,
 	address = FPGA_5GNR_FEC_RING_DESC_LEN;
 	fpga_reg_write_16(d->mmio_base, address, payload_16);
 
-	/* Setting FLR timeout value */
-	payload_16 = conf->flr_time_out;
-	address = FPGA_5GNR_FEC_FLR_TIME_OUT;
-	fpga_reg_write_16(d->mmio_base, address, payload_16);
-
 	/* Queue PF/VF mapping table is ready */
 	payload_8 = 0x1;
 	address = FPGA_5GNR_FEC_QUEUE_PF_VF_MAP_DONE;
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
index c2752fbd52..93a87c8e82 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
+++ b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
@@ -45,8 +45,6 @@ struct rte_fpga_5gnr_fec_conf {
 	uint8_t ul_load_balance;
 	/** DL Load Balance */
 	uint8_t dl_load_balance;
-	/** FLR timeout value */
-	uint16_t flr_time_out;
 };
 
 /**
-- 
2.25.1


  reply	other threads:[~2022-05-20  3:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  3:05 [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD Hernan Vargas
2022-05-20  3:05 ` Hernan Vargas [this message]
2022-05-20  3:05 ` [PATCH v2 2/5] baseband/fpga_5gnr_fec: add FPGA Mutex Hernan Vargas
2022-05-20  3:05 ` [PATCH v2 3/5] baseband/fpga_5gnr_fec: add check for HARQ input length Hernan Vargas
2022-05-20  3:05 ` [PATCH v2 4/5] baseband/fpga_5gnr_fec: enable validate LDPC enc/dec Hernan Vargas
2022-05-20  3:05 ` [PATCH v2 5/5] baseband/fpga_5gnr_fec: remove filler from HARQ Hernan Vargas
2022-05-24  0:21   ` Chautru, Nicolas
2022-05-31 18:06 ` [EXT] [PATCH v2 0/5] baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD Akhil Goyal
2022-05-31 18:12   ` Chautru, Nicolas
2022-05-31 18:17     ` Akhil Goyal
2022-05-31 18:30     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520030556.3475133-2-hernan.vargas@intel.com \
    --to=hernan.vargas@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).