From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Jan Viktorin <viktorin@rehivetech.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Joyce Kong <joyce.kong@arm.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] eal: remove unused arch specific headers for locks
Date: Tue, 7 Jun 2022 13:34:30 -0700 [thread overview]
Message-ID: <20220607133430.1737b4c4@hermes.local> (raw)
In-Reply-To: <20220607190308.1926702-1-david.marchand@redhat.com>
On Tue, 7 Jun 2022 21:03:08 +0200
David Marchand <david.marchand@redhat.com> wrote:
> MCS lock, PF lock and Ticket lock have no arch specific implementation,
> there is no need for the extra redirection in headers.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Note: this was mentionned during the seqlock patch review, and I spotted
> it again, while reviewing the RISC-V port, and I see the same for a next
> architecture too. So better clean this up as we don't need the
> redirection.
>
> ---
> MAINTAINERS | 4 ++--
> lib/eal/arm/include/meson.build | 3 ---
> lib/eal/arm/include/rte_mcslock.h | 22 -------------------
> lib/eal/arm/include/rte_pflock.h | 18 ---------------
> lib/eal/arm/include/rte_ticketlock.h | 22 -------------------
> lib/eal/include/meson.build | 6 ++---
> lib/eal/include/{generic => }/rte_mcslock.h | 8 +++++++
> lib/eal/include/{generic => }/rte_pflock.h | 0
> .../include/{generic => }/rte_ticketlock.h | 0
> lib/eal/ppc/include/meson.build | 3 ---
> lib/eal/ppc/include/rte_mcslock.h | 18 ---------------
> lib/eal/ppc/include/rte_pflock.h | 17 --------------
> lib/eal/ppc/include/rte_ticketlock.h | 18 ---------------
> lib/eal/x86/include/meson.build | 3 ---
> lib/eal/x86/include/rte_mcslock.h | 18 ---------------
> lib/eal/x86/include/rte_pflock.h | 18 ---------------
> lib/eal/x86/include/rte_ticketlock.h | 18 ---------------
> 17 files changed, 13 insertions(+), 183 deletions(-)
> delete mode 100644 lib/eal/arm/include/rte_mcslock.h
> delete mode 100644 lib/eal/arm/include/rte_pflock.h
> delete mode 100644 lib/eal/arm/include/rte_ticketlock.h
> rename lib/eal/include/{generic => }/rte_mcslock.h (98%)
> rename lib/eal/include/{generic => }/rte_pflock.h (100%)
> rename lib/eal/include/{generic => }/rte_ticketlock.h (100%)
> delete mode 100644 lib/eal/ppc/include/rte_mcslock.h
> delete mode 100644 lib/eal/ppc/include/rte_pflock.h
> delete mode 100644 lib/eal/ppc/include/rte_ticketlock.h
> delete mode 100644 lib/eal/x86/include/rte_mcslock.h
> delete mode 100644 lib/eal/x86/include/rte_pflock.h
> delete mode 100644 lib/eal/x86/include/rte_ticketlock.h
>
Looks great will make future work easier.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-06-07 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 19:03 David Marchand
2022-06-07 20:34 ` Stephen Hemminger [this message]
2022-06-08 11:57 ` [PATCH v2] " David Marchand
2022-06-08 13:16 ` Stanisław Kardach
2022-06-08 13:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607133430.1737b4c4@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=joyce.kong@arm.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).