From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: [RFC 5/8] test/ipsec: fix gcc-12 rte_memcpy warnings
Date: Tue, 7 Jun 2022 10:17:43 -0700 [thread overview]
Message-ID: <20220607171746.461772-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20220607171746.461772-1-stephen@networkplumber.org>
It is not necessary to use rte_memcpy here, and it can cause
warnings when gcc-12 detects that rte_memcpy will derference past
input data.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_ipsec.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index 8da025bf6621..4aa9b346646d 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -10,7 +10,6 @@
#include <rte_hexdump.h>
#include <rte_mbuf.h>
#include <rte_malloc.h>
-#include <rte_memcpy.h>
#include <rte_cycles.h>
#include <rte_bus_vdev.h>
#include <rte_ip.h>
@@ -569,7 +568,7 @@ setup_test_string(struct rte_mempool *mpool,
return NULL;
}
if (string != NULL)
- rte_memcpy(dst, string, t_len);
+ memcpy(dst, string, t_len);
else
memset(dst, 0, t_len);
}
@@ -614,21 +613,21 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string,
/* copy outer IP and ESP header */
ipv4_outer.total_length = rte_cpu_to_be_16(t_len);
ipv4_outer.packet_id = rte_cpu_to_be_16(seq);
- rte_memcpy(dst, &ipv4_outer, sizeof(ipv4_outer));
+ memcpy(dst, &ipv4_outer, sizeof(ipv4_outer));
dst += sizeof(ipv4_outer);
m->l3_len = sizeof(ipv4_outer);
- rte_memcpy(dst, &esph, sizeof(esph));
+ memcpy(dst, &esph, sizeof(esph));
dst += sizeof(esph);
if (string != NULL) {
/* copy payload */
- rte_memcpy(dst, string, len);
+ memcpy(dst, string, len);
dst += len;
/* copy pad bytes */
- rte_memcpy(dst, esp_pad_bytes, padlen);
+ memcpy(dst, esp_pad_bytes, padlen);
dst += padlen;
/* copy ESP tail header */
- rte_memcpy(dst, &espt, sizeof(espt));
+ memcpy(dst, &espt, sizeof(espt));
} else
memset(dst, 0, t_len);
--
2.35.1
next prev parent reply other threads:[~2022-06-07 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 17:17 [RFC 0/8] Gcc-12 warning fixes Stephen Hemminger
2022-06-07 17:17 ` [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12 Stephen Hemminger
2022-06-08 12:29 ` Michał Krawczyk
2022-06-08 15:32 ` Stephen Hemminger
2022-06-08 19:18 ` Michał Krawczyk
2022-06-08 20:52 ` Stephen Hemminger
2022-06-07 17:17 ` [RFC 2/8] net/qede: fix gcc-12 rte_memcpy warnings Stephen Hemminger
2022-06-23 14:16 ` David Marchand
2022-06-07 17:17 ` [RFC 3/8] net/ice: fix rte_memcpy warnings with gcc-12 Stephen Hemminger
2022-06-07 17:17 ` [RFC 4/8] test/ipfrag: fix gcc-12 warnings Stephen Hemminger
2022-06-07 17:17 ` Stephen Hemminger [this message]
2022-06-07 17:17 ` [RFC 6/8] net/enetfc: fix array out of bounds warning Stephen Hemminger
2022-06-07 17:17 ` [RFC 7/8] vhost: replace rte_memcpy to fix warning Stephen Hemminger
2022-06-07 17:17 ` [RFC 8/8] ip_frag: fix gcc-12 warnings Stephen Hemminger
2022-06-08 8:19 ` Konstantin Ananyev
2022-06-08 15:26 ` Stephen Hemminger
2022-06-09 7:09 ` Morten Brørup
2022-06-14 21:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607171746.461772-6-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).