From: Stanislaw Kardach <kda@semihalf.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: Stanislaw Kardach <kda@semihalf.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, upstream@semihalf.com
Subject: [PATCH 2/3] lpm: fix xmm_t casting for C++ in scalar version
Date: Thu, 9 Jun 2022 14:17:00 +0200 [thread overview]
Message-ID: <20220609121701.716299-3-kda@semihalf.com> (raw)
In-Reply-To: <20220609121701.716299-1-kda@semihalf.com>
rte_xmm_t is a union type which wraps around xmm_t and maps its contents
to scalar structures. Since C++ has stricter type conversion rules than
C, the rte_xmm_t::x has to be used instead of C-casting.
The generated assembly is identical to the code without the fix (checked
both on x86 and RISC-V).
Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
lib/lpm/rte_lpm_scalar.h | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/lpm/rte_lpm_scalar.h b/lib/lpm/rte_lpm_scalar.h
index f0d9f37894..161b40ff80 100644
--- a/lib/lpm/rte_lpm_scalar.h
+++ b/lib/lpm/rte_lpm_scalar.h
@@ -15,18 +15,19 @@ extern "C" {
static inline void
rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],
- uint32_t defv)
+ uint32_t defv)
{
+ rte_xmm_t xip = { .x = ip };
uint32_t nh;
int ret;
- ret = rte_lpm_lookup(lpm, ((rte_xmm_t)ip).u32[0], &nh);
+ ret = rte_lpm_lookup(lpm, xip.u32[0], &nh);
hop[0] = (ret == 0) ? nh : defv;
- ret = rte_lpm_lookup(lpm, ((rte_xmm_t)ip).u32[1], &nh);
+ ret = rte_lpm_lookup(lpm, xip.u32[1], &nh);
hop[1] = (ret == 0) ? nh : defv;
- ret = rte_lpm_lookup(lpm, ((rte_xmm_t)ip).u32[2], &nh);
+ ret = rte_lpm_lookup(lpm, xip.u32[2], &nh);
hop[2] = (ret == 0) ? nh : defv;
- ret = rte_lpm_lookup(lpm, ((rte_xmm_t)ip).u32[3], &nh);
+ ret = rte_lpm_lookup(lpm, xip.u32[3], &nh);
hop[3] = (ret == 0) ? nh : defv;
}
--
2.30.2
next prev parent reply other threads:[~2022-06-09 12:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 12:16 [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion Stanislaw Kardach
2022-06-09 12:16 ` [PATCH 1/3] eal/riscv: fix xmm_t casting for C++ Stanislaw Kardach
2022-06-13 9:29 ` David Marchand
2022-06-09 12:17 ` Stanislaw Kardach [this message]
2022-06-13 9:29 ` [PATCH 2/3] lpm: fix xmm_t casting for C++ in scalar version David Marchand
2022-06-09 12:17 ` [PATCH 3/3] ci: use crossbuild-essential-riscv64 for compiling Stanislaw Kardach
2022-06-13 9:29 ` David Marchand
2022-06-14 12:31 ` Aaron Conole
2022-06-15 7:25 ` [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion David Marchand
2022-06-20 22:54 ` David Christensen
2022-06-21 9:30 ` Stanisław Kardach
2022-06-21 9:38 ` Bruce Richardson
2022-06-21 9:42 ` Stanisław Kardach
2022-06-21 9:49 ` Bruce Richardson
2022-06-21 10:22 ` Thomas Monjalon
2022-06-21 11:05 ` Stanisław Kardach
2022-06-21 11:53 ` Thomas Monjalon
2022-06-21 12:37 ` Stanisław Kardach
2022-06-21 14:20 ` Bruce Richardson
2022-06-21 19:48 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609121701.716299-3-kda@semihalf.com \
--to=kda@semihalf.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=upstream@semihalf.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).