DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alex Kiselev <alex@bisonrouter.com>
Cc: dev@dpdk.org, Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH] net/tap: fix the overflow of the network interface index.
Date: Thu, 21 Jul 2022 08:19:21 -0700	[thread overview]
Message-ID: <20220721081921.37221f7c@hermes.local> (raw)
In-Reply-To: <20220721111301.2106005-2-alex@bisonrouter.com>

On Thu, 21 Jul 2022 11:13:01 +0000
Alex Kiselev <alex@bisonrouter.com> wrote:

> On Linux and most other systems, network interface index is a 32-bit
> integer.  Indexes overflowing the 16-bit integer are frequently seen
> when used inside a Docker container.
> 
> Signed-off-by: Alex Kiselev <alex@bisonrouter.com>

Looks good, Linux API is inconsistent in use of signed vs unsigned
int for the ifindex. But negative values are never used/returned.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

  reply	other threads:[~2022-07-21 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 11:13 Alex Kiselev
2022-07-21 11:13 ` Alex Kiselev
2022-07-21 15:19   ` Stephen Hemminger [this message]
2022-10-04 14:34     ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220721081921.37221f7c@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=alex@bisonrouter.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).