From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mário Kuka" <kuka@cesnet.cz>
Cc: dev@dpdk.org, mdr@ashroe.eu, reshma.pattan@intel.com
Subject: Re: [PATCH v2 2/2] pcapng: check if writev() returns a partial write
Date: Fri, 29 Jul 2022 09:00:28 -0700 [thread overview]
Message-ID: <20220729090028.25674943@hermes.local> (raw)
In-Reply-To: <20220729071841.18198-3-kuka@cesnet.cz>
On Fri, 29 Jul 2022 09:18:41 +0200
Mário Kuka <kuka@cesnet.cz> wrote:
> +pcapng_writev(int fd, struct iovec *iov, const int count)
> +{
> + size_t total = 0;
> + int at = 0;
> +
> + while (at < count) {
> + /*
> + * Note: writev() can return the following on a write request:
> + * Complete:
> + * written = [sum of all iov.iov_len]
> + * Partial:
> + * written < [sum of all iov.iov_len]
> + * Deferred:
> + * written = -1, errno = [EAGAIN]
> + *
> + * Partial and deferred writes are only possible with O_NONBLOCK set.
> + *
> + * If we get a partial result, we have to call the writev() again on any ivo buffers
> + * that have not been fully written.
> + */
> + ssize_t written = writev(fd, &iov[at], count - at);
> + if (unlikely(written < 0))
> + return written;
> +
> + total += written;
> + at += pcapng_update_iov(&iov[at], count - at, written);
> + }
> +
> + return total;
Since this is being written to a file, handling partial writes makes little
sense. The only case where partial write would happen would be if filesystem
was full. Retrying just adds unnecessary complexity.
If you really want to track this, then add a dropped counter.
next prev parent reply other threads:[~2022-07-29 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 15:28 [PATCH] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-07-25 15:57 ` Stephen Hemminger
2022-07-25 16:10 ` Stephen Hemminger
2022-07-29 7:18 ` [PATCH v2 0/2] pcapng: fix some issues with writing packets Mário Kuka
2022-07-29 7:18 ` [PATCH v2 1/2] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-07-29 7:18 ` [PATCH v2 2/2] pcapng: check if writev() returns a partial write Mário Kuka
2022-07-29 16:00 ` Stephen Hemminger [this message]
2022-07-29 17:08 ` Mário Kuka
2022-07-29 18:14 ` Stephen Hemminger
2022-08-01 8:42 ` Mário Kuka
2022-07-29 15:58 ` [PATCH v2 0/2] pcapng: fix some issues with writing packets Stephen Hemminger
2022-07-29 17:33 ` Mário Kuka
2022-08-01 8:40 ` [PATCH v3] pcapng: fix write more packets than IOV_MAX limit Mário Kuka
2022-08-01 15:33 ` Stephen Hemminger
2022-10-10 0:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729090028.25674943@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=kuka@cesnet.cz \
--cc=mdr@ashroe.eu \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).