From: Stephen Hemminger <stephen@networkplumber.org>
To: Francesco Mancino <francesco.mancino@tutus.se>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/tap: Allow jumbo frames
Date: Mon, 8 Aug 2022 07:41:19 -0700 [thread overview]
Message-ID: <20220808074119.120c63c1@hermes.local> (raw)
In-Reply-To: <315474c3-7004-2114-9e24-8344da7aca9e@tutus.se>
On Mon, 8 Aug 2022 11:31:16 +0200
Francesco Mancino <francesco.mancino@tutus.se> wrote:
> eth_dev_validate_mtu, introduced in 990912e676e, validates configured
> MTU plus overhead against max_rx_pktlen.
> Since TAP is a virtual device, it should support as big MTU as possible.
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 9e1032fe72..54ca4ca5e9 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1066,7 +1066,7 @@ tap_dev_info(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>
> dev_info->if_index = internals->if_index;
> dev_info->max_mac_addrs = 1;
> - dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_VLAN_FRAME_LEN;
> + dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_JUMBO_FRAME_LEN;
> dev_info->max_rx_queues = RTE_PMD_TAP_MAX_QUEUES;
> dev_info->max_tx_queues = RTE_PMD_TAP_MAX_QUEUES;
> dev_info->min_rx_bufsize = 0;
> --
> 2.34.1
>
>
OK but cast is not needed.
It wasn't needed before and not needed now.
By not having the cast the code has better chance of catching any issues
if sizes mismatch.
next prev parent reply other threads:[~2022-08-08 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 9:31 Francesco Mancino
2022-08-08 14:41 ` Stephen Hemminger [this message]
2022-08-08 14:49 ` [PATCH v7] " Francesco Mancino
2022-08-08 15:03 ` Stephen Hemminger
2022-08-08 15:38 ` Francesco Mancino
2022-08-08 16:42 ` Stephen Hemminger
2022-08-09 7:57 ` Francesco Mancino
2023-01-19 14:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808074119.120c63c1@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=francesco.mancino@tutus.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).