From: Stephen Hemminger <stephen@networkplumber.org>
To: Joyce Kong <joyce.kong@arm.com>
Cc: jgrajcia@cisco.com, huzaifa.rahman@emumba.com, dev@dpdk.org,
nd@arm.com, mb@smartsharesystems.com, ruifeng.wang@arm.com
Subject: Re: [PATCH v3 1/2] net/memif: add a Rx fast path
Date: Wed, 31 Aug 2022 09:25:50 -0700 [thread overview]
Message-ID: <20220831092550.788683ac@hermes.local> (raw)
In-Reply-To: <20220822034731.528424-2-joyce.kong@arm.com>
On Mon, 22 Aug 2022 03:47:30 +0000
Joyce Kong <joyce.kong@arm.com> wrote:
> + if (likely(mbuf_size >= pmd->cfg.pkt_buffer_size)) {
> + struct rte_mbuf *mbufs[nb_pkts];
> + ret = rte_pktmbuf_alloc_bulk(mq->mempool, mbufs, nb_pkts);
> + if (unlikely(ret < 0))
> + goto no_free_bufs;
> +
The indentation looks off here, is this because of diff?
Also, my preference is to use blank line after declaration.
One more thing, the use of variable length array on stack will cause
the function to get additional overhead if stack-protector strong is
enabled.
next prev parent reply other threads:[~2022-08-31 16:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 9:32 [RFC] net/memif: add a fast path for Rx Joyce Kong
2022-05-17 10:51 ` [PATCH v1 0/2] add a fast path for memif Rx/Tx Joyce Kong
2022-05-17 10:51 ` [PATCH v1 1/2] net/memif: add a Rx fast path Joyce Kong
2022-05-18 16:53 ` Ferruh Yigit
2022-05-19 7:00 ` Joyce Kong
2022-05-19 8:44 ` Joyce Kong
2022-05-18 17:06 ` Ferruh Yigit
2022-05-19 15:09 ` Joyce Kong
2022-05-19 16:38 ` Ferruh Yigit
2022-05-17 10:51 ` [PATCH v1 2/2] net/memif: add a Tx " Joyce Kong
2022-05-17 13:59 ` [PATCH v1 0/2] add a fast path for memif Rx/Tx Morten Brørup
2022-05-18 2:48 ` Ruifeng Wang
2022-07-01 10:28 ` [PATCH v2 " Joyce Kong
2022-07-01 10:28 ` [PATCH v2 1/2] net/memif: add a Rx fast path Joyce Kong
2022-07-01 16:51 ` Stephen Hemminger
2022-08-22 3:47 ` [PATCH v3 0/2] add a fast path for memif Rx/Tx Joyce Kong
2022-08-22 3:47 ` [PATCH v3 1/2] net/memif: add a Rx fast path Joyce Kong
2022-08-31 16:25 ` Stephen Hemminger [this message]
2022-09-07 6:06 ` Joyce Kong
2022-08-22 3:47 ` [PATCH v3 2/2] net/memif: add a Tx " Joyce Kong
2022-07-01 10:28 ` [PATCH v2 " Joyce Kong
2022-09-15 6:58 ` [PATCH v4 0/2] add a fast path for memif Rx/Tx Joyce Kong
2022-09-15 6:58 ` [PATCH v4 1/2] net/memif: add a Rx fast path Joyce Kong
2022-09-15 6:58 ` [PATCH v4 2/2] net/memif: add a Tx " Joyce Kong
2022-09-22 9:12 ` [PATCH v4 0/2] add a fast path for memif Rx/Tx Ferruh Yigit
2022-12-09 13:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831092550.788683ac@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=huzaifa.rahman@emumba.com \
--cc=jgrajcia@cisco.com \
--cc=joyce.kong@arm.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).