From: Stephen Hemminger <stephen@networkplumber.org>
To: Michael Piszczek <mpiszczek@ddn.com>
Cc: dev@dpdk.org, Vipin.Varghese@amd.com
Subject: Re: [PATCH v4] pci: read amd iommu virtual address width
Date: Wed, 12 Oct 2022 08:15:31 -0700 [thread overview]
Message-ID: <20221012081531.722f9f6d@hermes.local> (raw)
In-Reply-To: <20221011140854.777428-1-mpiszczek@ddn.com>
On Tue, 11 Oct 2022 16:08:53 +0200
Michael Piszczek <mpiszczek@ddn.com> wrote:
> + mgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;
> }
> + else {
Minor nit, the kernel style used by DPDK uses "cuddle else"
} else {
next prev parent reply other threads:[~2022-10-12 15:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 16:01 [PATCH 0/1] " Michael Piszczek
2022-09-12 16:01 ` [PATCH 1/1] " Michael Piszczek
2022-09-14 13:49 ` [PATCH v2] " Michael Piszczek
2022-10-03 7:48 ` David Marchand
2022-10-10 13:12 ` Varghese, Vipin
2022-10-10 21:47 ` [PATCH v3] " Michael Piszczek
2022-10-10 21:47 ` Michael Piszczek
2022-10-11 22:00 ` Ferruh Yigit
2022-10-11 14:08 ` [PATCH v4] " Michael Piszczek
2022-10-11 14:08 ` Michael Piszczek
2022-10-12 9:18 ` Ferruh Yigit
2022-10-12 15:15 ` Stephen Hemminger [this message]
2022-10-13 18:16 ` [PATCH v5] " Michael Piszczek
2022-10-13 18:16 ` Michael Piszczek
2022-10-24 18:09 ` Stephen Hemminger
2022-10-25 7:56 ` Ferruh Yigit
2022-10-17 15:45 ` [PATCH v6] " Michael Piszczek
2022-10-17 15:45 ` Michael Piszczek
2022-10-25 11:54 ` David Marchand
2023-08-08 7:31 ` David Marchand
2023-08-08 13:53 ` Michael Piszczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012081531.722f9f6d@hermes.local \
--to=stephen@networkplumber.org \
--cc=Vipin.Varghese@amd.com \
--cc=dev@dpdk.org \
--cc=mpiszczek@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).