From: Stephen Hemminger <stephen@networkplumber.org>
To: Huisong Li <lihuisong@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>,
<andrew.rybchenko@oktetlabs.ru>, <3chas3@gmail.com>,
<humin29@huawei.com>, <liudongdong3@huawei.com>,
<huangdaode@huawei.com>
Subject: Re: [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free
Date: Tue, 8 Nov 2022 19:24:17 -0800 [thread overview]
Message-ID: <20221108192417.35ab2959@hermes.local> (raw)
In-Reply-To: <20221109022237.49757-1-lihuisong@huawei.com>
On Wed, 9 Nov 2022 10:22:37 +0800
Huisong Li <lihuisong@huawei.com> wrote:
> The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding
> mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes
> from the dev->data->dev_conf.txmode.offloads and processes as success in
> bond_ethdev_configure(). But this still cause that rte_eth_dev_configure()
> fails to execute because of the failure of validating Tx offload in the
> eth_dev_validate_offloads(). So this patch moves the modification of txmode
> offlaods to the stage of adding slave device to report the correct txmode
> offloads.
>
> Fixes: 18c41457cbae ("net/bonding: fix mbuf fast free usage")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
Looks good thanks.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2022-11-09 3:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 8:40 [PATCH 0/2] net/bonding: fix mbuf fast free for bond3 and bond4 Huisong Li
2022-11-08 8:40 ` [PATCH 1/2] net/bonding: fix bond3 and bond4 process mbuf fast free Huisong Li
2022-11-08 8:40 ` [PATCH 2/2] app/testpmd: remove fast free offload for bond3 and bond4 Huisong Li
2022-11-08 18:01 ` Stephen Hemminger
2022-11-09 1:11 ` lihuisong (C)
2022-11-09 2:22 ` [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free Huisong Li
2022-11-09 3:24 ` Stephen Hemminger [this message]
2022-11-09 10:37 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108192417.35ab2959@hermes.local \
--to=stephen@networkplumber.org \
--cc=3chas3@gmail.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=huangdaode@huawei.com \
--cc=humin29@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).