From: Stephen Hemminger <stephen@networkplumber.org>
To: madhuker.mythri@oracle.com
Cc: grive@u256.net, dev@dpdk.org
Subject: Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id
Date: Wed, 16 Nov 2022 09:51:36 -0800 [thread overview]
Message-ID: <20221116095136.498b2141@hermes.local> (raw)
In-Reply-To: <20221116095224.1576-1-madhuker.mythri@oracle.com>
On Wed, 16 Nov 2022 15:22:24 +0530
madhuker.mythri@oracle.com wrote:
>
> + if (!rte_eth_dev_is_valid_port(PORT_ID(sdev))) {
> + continue;
> + }
> +
Looks ok but DPDK follows kernel style {} is unnecessary on single statement.
Checkpatch will give you warnings on this.
next prev parent reply other threads:[~2022-11-16 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:52 madhuker.mythri
2022-11-16 17:51 ` Stephen Hemminger [this message]
2022-11-16 12:11 madhuker.mythri
2022-12-07 17:21 ` Ferruh Yigit
2023-10-17 16:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116095136.498b2141@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=madhuker.mythri@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).