From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: "David Marchand" <david.marchand@redhat.com>,
dev@dpdk.org, stable@dpdk.org,
"Luca Boccassi" <luca.boccassi@microsoft.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted
Date: Thu, 1 Dec 2022 16:11:13 -0800 [thread overview]
Message-ID: <20221202001113.GI24029@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <f1c5cbed-e40b-ba80-98ac-b5385f612b6b@amd.com>
On Tue, Nov 29, 2022 at 06:23:21PM +0000, Ferruh Yigit wrote:
> On 11/29/2022 2:00 PM, David Marchand wrote:
> > ld exports any global symbol by default if no version script is passed.
> > As a consequence, the incriminated change let any public symbol leak
> > out of the driver shared libraries.
> >
>
> Not tested on Windows, but for Linux:
just for awareness the default is the opposite on windows symbols are
private by default and have to be explicitly made public.
also, for gcc we could go to the extreme and pass -fvisibility=hidden
and fix out any other symbols that are missed.
if you're really going wild you may consider introducing a macro that
can be expanded to __attribute__((visibility("default"))) combined with
-fvisibility=hidden (as opposed to version.map) the main benefit being
there's only a single source of truth about whether or not the symbol is
public, you don't have to look in 2 places.
(anyway, probably not a popular idea...)
ty
next prev parent reply other threads:[~2022-12-02 0:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 14:00 David Marchand
2022-11-29 18:23 ` Ferruh Yigit
2022-11-30 7:13 ` David Marchand
2022-11-30 8:27 ` David Marchand
2022-11-30 9:19 ` Ferruh Yigit
2022-12-02 0:11 ` Tyler Retzlaff [this message]
2022-11-30 10:02 ` [PATCH v2] " David Marchand
2022-11-30 10:44 ` Ferruh Yigit
2022-11-30 15:02 ` David Marchand
2022-11-30 15:24 ` David Marchand
2022-11-30 15:42 ` Bruce Richardson
2022-12-01 10:11 ` David Marchand
2022-12-01 10:08 ` [PATCH v3 1/2] " David Marchand
2022-12-01 10:55 ` Bruce Richardson
2022-12-02 10:01 ` David Marchand
2022-12-02 11:09 ` [PATCH v4 " David Marchand
2022-12-02 13:39 ` Aaron Conole
2022-12-05 10:23 ` David Marchand
2022-12-05 10:43 ` [EXT] " Akhil Goyal
2022-12-05 12:36 ` David Marchand
2022-12-05 13:47 ` Akhil Goyal
2022-12-05 15:37 ` Thomas Monjalon
2022-12-05 16:26 ` Akhil Goyal
2022-12-06 10:12 ` Ferruh Yigit
2022-12-06 10:18 ` David Marchand
2022-12-06 12:25 ` Ferruh Yigit
2022-12-07 18:00 ` Patrick Robb
2022-12-08 13:22 ` Thomas Monjalon
2022-12-08 16:06 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202001113.GI24029@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=luca.boccassi@microsoft.com \
--cc=omer.yamac@ceng.metu.edu.tr \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).