DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nicolas Chautru <nicolas.chautru@intel.com>
To: dev@dpdk.org, maxime.coquelin@redhat.com
Cc: hernan.vargas@intel.com, Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [PATCH v1 3/3] app/bbdev-test: remove offload cost optional build flag
Date: Wed, 14 Dec 2022 23:33:46 +0000	[thread overview]
Message-ID: <20221214233346.391973-4-nicolas.chautru@intel.com> (raw)
In-Reply-To: <20221214233346.391973-1-nicolas.chautru@intel.com>

Remove the optional build flag for bbdev-test application
so that it is enabled by default and having to maintain single
build variant.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index b2096525ea..3818b74c79 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -166,7 +166,6 @@ struct thread_params {
 	struct rte_bbdev_fft_op *fft_ops[MAX_BURST];
 };
 
-#ifdef RTE_BBDEV_OFFLOAD_COST
 /* Stores time statistics */
 struct test_time_stats {
 	/* Stores software enqueue total working time */
@@ -188,7 +187,6 @@ struct test_time_stats {
 	/* Stores maximum value of dequeue working time */
 	uint64_t deq_max_time;
 };
-#endif
 
 typedef int (test_case_function)(struct active_device *ad,
 		struct test_op_params *op_params);
@@ -4916,7 +4914,6 @@ validation_test(struct active_device *ad, struct test_op_params *op_params)
 	return validation_latency_test(ad, op_params, false);
 }
 
-#ifdef RTE_BBDEV_OFFLOAD_COST
 static int
 get_bbdev_queue_stats(uint16_t dev_id, uint16_t queue_id,
 		struct rte_bbdev_stats *stats)
@@ -5367,19 +5364,11 @@ offload_latency_test_ldpc_enc(struct rte_mempool *mempool,
 
 	return i;
 }
-#endif
 
 static int
 offload_cost_test(struct active_device *ad,
 		struct test_op_params *op_params)
 {
-#ifndef RTE_BBDEV_OFFLOAD_COST
-	RTE_SET_USED(ad);
-	RTE_SET_USED(op_params);
-	printf("Offload latency test is disabled.\n");
-	printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n");
-	return TEST_SKIPPED;
-#else
 	int iter;
 	uint16_t burst_sz = op_params->burst_sz;
 	const uint16_t num_to_process = op_params->num_to_process;
@@ -5492,10 +5481,8 @@ offload_cost_test(struct active_device *ad,
 			stats.dequeue_err_count);
 
 	return TEST_SUCCESS;
-#endif
 }
 
-#ifdef RTE_BBDEV_OFFLOAD_COST
 static int
 offload_latency_empty_q_test_dec(uint16_t dev_id, uint16_t queue_id,
 		const uint16_t num_to_process, uint16_t burst_sz,
@@ -5563,19 +5550,10 @@ offload_latency_empty_q_test_enc(uint16_t dev_id, uint16_t queue_id,
 	return i;
 }
 
-#endif
-
 static int
 offload_latency_empty_q_test(struct active_device *ad,
 		struct test_op_params *op_params)
 {
-#ifndef RTE_BBDEV_OFFLOAD_COST
-	RTE_SET_USED(ad);
-	RTE_SET_USED(op_params);
-	printf("Offload latency empty dequeue test is disabled.\n");
-	printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n");
-	return TEST_SKIPPED;
-#else
 	int iter;
 	uint64_t deq_total_time, deq_min_time, deq_max_time;
 	uint16_t burst_sz = op_params->burst_sz;
@@ -5625,7 +5603,6 @@ offload_latency_empty_q_test(struct active_device *ad,
 			rte_get_tsc_hz());
 
 	return TEST_SUCCESS;
-#endif
 }
 
 static int
-- 
2.34.1


  parent reply	other threads:[~2022-12-14 23:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 23:33 [PATCH v1 0/3] bbdev: remove offload cost Nicolas Chautru
2022-12-14 23:33 ` [PATCH v1 1/3] test/bbdev: explicit check for allocation failure Nicolas Chautru
2023-01-06 14:51   ` Maxime Coquelin
2023-01-06 15:37     ` Chautru, Nicolas
2023-01-10  8:32   ` Maxime Coquelin
2022-12-14 23:33 ` [PATCH v1 2/3] drivers/baseband: remove offload cost optional build flag Nicolas Chautru
2023-01-06 14:54   ` Maxime Coquelin
2022-12-14 23:33 ` Nicolas Chautru [this message]
2023-01-06 14:55   ` [PATCH v1 3/3] app/bbdev-test: " Maxime Coquelin
2023-01-03 22:07 ` [PATCH v1 0/3] bbdev: remove offload cost Chautru, Nicolas
2023-01-04 12:42   ` Maxime Coquelin
2023-01-04 18:01     ` Chautru, Nicolas
2023-01-05  9:53       ` Maxime Coquelin
2023-01-10  8:43 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214233346.391973-4-nicolas.chautru@intel.com \
    --to=nicolas.chautru@intel.com \
    --cc=dev@dpdk.org \
    --cc=hernan.vargas@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).