From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] eal: add missing call marking memory config complete
Date: Thu, 15 Dec 2022 10:07:32 -0800 [thread overview]
Message-ID: <20221215180732.GE17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8z-r5E=wKWu7N+=LmkKFDH-5=Px7VpcHtaFP0iRuwcu9A@mail.gmail.com>
On Thu, Dec 15, 2022 at 10:59:07AM +0100, David Marchand wrote:
> On Tue, Dec 6, 2022 at 1:39 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Memory configuration was not being marked as completed add the missing
> > call to rte_eal_init() for Windows.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> The change is ok.
>
> The commitlog misses some context: I guess the point is to let
> rte_thread_register work on Windows.
oh i guess i better provide a better message. the reason is i want to
run the test_ctrl_thread() (in test_lcores.c) which is an api available
on windows. maybe when i add the replacement control thread creation it
should be moved to / live in test_threads.c?
it is nice as a side-effect it did pick up that the mcfg hadn't been
marked as done. (though i understand that's not the purpose of the
test).
i'll have another whack at changing the log.
> So we can mark this change as:
> Fixes: 5c307ba2a5b1 ("eal: register non-EAL threads as lcores")
>
> WDYT?
yep, v2 will fix the message & the Fixes tag.
>
>
> In any case, this change won't fix anything related to mp.
> If mp is supported one day on Windows, other calls to eal_mcfg* would
> be required.
agreed.
>
> --
> David Marchand
next prev parent reply other threads:[~2022-12-15 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 0:39 [PATCH 0/2] enable lcores test on Windows Tyler Retzlaff
2022-12-06 0:39 ` [PATCH 1/2] eal: add missing call marking memory config complete Tyler Retzlaff
2022-12-14 16:52 ` Stephen Hemminger
2022-12-15 9:59 ` David Marchand
2022-12-15 18:07 ` Tyler Retzlaff [this message]
2022-12-06 0:39 ` [PATCH 2/2] test: enable lcores test on Windows Tyler Retzlaff
2022-12-14 16:53 ` Stephen Hemminger
2022-12-12 20:36 ` [PATCH 0/2] " Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 1/2] eal: add missing call marking memory config complete Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 2/2] test: enable lcores test on Windows Tyler Retzlaff
2022-12-21 15:03 ` [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215180732.GE17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).