From: Stephen Hemminger <stephen@networkplumber.org>
To: Ben Magistro <koncept1@gmail.com>
Cc: dev@dpdk.org, ben.magistro@trinitycyber.com, stable@dpdk.org
Subject: Re: [PATCH 2/6] app/dumpcap: fix storing port identifier
Date: Mon, 2 Jan 2023 08:58:02 -0800 [thread overview]
Message-ID: <20230102085802.76a54cd2@hermes.local> (raw)
In-Reply-To: <20230102162441.6205-2-koncept1@gmail.com>
On Mon, 2 Jan 2023 16:24:37 +0000
Ben Magistro <koncept1@gmail.com> wrote:
> When dumpcap adds an interface, the port was not being preserved. This
> results in the structure being initialized and the port field being set
> to 0 regardless of what port was actually selected. This unset field is
> then used in both the enable and cleanup calls. This could result in the
> capture occurring on the wrong interface.
>
> Fixes: d59fb4d ("app/dumpcap: add new packet capture application")
> Cc: stephen@networkplumber.org
> Cc: stable@dpdk.org
>
> Signed-off-by: Ben Magistro <koncept1@gmail.com>
> ---
> app/dumpcap/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index b9096f050c..aaee9349b1 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -202,6 +202,7 @@ static void add_interface(uint16_t port, const char *name)
> rte_exit(EXIT_FAILURE, "no memory for interface\n");
>
> memset(intf, 0, sizeof(*intf));
> + intf->port = port;
> rte_strscpy(intf->name, name, sizeof(intf->name));
>
> printf("Capturing on '%s'\n", name);
Will be superseded by my fixes to port setup.
next prev parent reply other threads:[~2023-01-02 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230102162441.6205-1-koncept1@gmail.com>
2023-01-02 16:24 ` Ben Magistro
2023-01-02 16:58 ` Stephen Hemminger [this message]
2023-01-04 3:04 ` Stephen Hemminger
2023-01-02 16:24 ` [PATCH 3/6] app/dumpcap: fix preserving promiscuous mode Ben Magistro
2023-01-02 16:58 ` Stephen Hemminger
2023-01-04 3:04 ` Stephen Hemminger
2023-01-02 16:24 ` [PATCH 4/6] app/dumpcap: fix capturing on multiple interfaces Ben Magistro
2023-01-04 3:01 ` Stephen Hemminger
[not found] ` <20230104033815.35496-1-stephen@networkplumber.org>
2023-01-04 3:38 ` [PATCH v2 1/6] app/dumpcap: fix storing port identifier Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102085802.76a54cd2@hermes.local \
--to=stephen@networkplumber.org \
--cc=ben.magistro@trinitycyber.com \
--cc=dev@dpdk.org \
--cc=koncept1@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).