From: Stephen Hemminger <stephen@networkplumber.org>
To: Ben Magistro <koncept1@gmail.com>
Cc: dev@dpdk.org, ben.magistro@trinitycyber.com
Subject: Re: [PATCH 5/6] app/dumpcap: improve per interface arg parsing
Date: Tue, 3 Jan 2023 19:04:18 -0800 [thread overview]
Message-ID: <20230103190418.22ed1fce@hermes.local> (raw)
In-Reply-To: <20230102162441.6205-5-koncept1@gmail.com>
On Mon, 2 Jan 2023 16:24:40 +0000
Ben Magistro <koncept1@gmail.com> wrote:
> +
> +/* struct representing args for each interface */
> +struct interface_opts {
> + const char *intf_arg;
> + const char *filter_str;
> + bool promiscuous_mode;
> + uint32_t snaplen;
> +};
> +/* default parameters for interfaces */
> +static struct interface_opts interface_defaults = {
> + .promiscuous_mode = true,
> + .snaplen = RTE_MBUF_DEFAULT_BUF_SIZE
> +};
> +//TODO this can be specified per interface but there are a few places
> +// that need more review and possibly refactoring so leaving this one out
> +uint32_t snaplen = RTE_MBUF_DEFAULT_BUF_SIZE;
> +/* array of interface parameters */
> +static struct interface_opts interface_args[RTE_MAX_ETHPORTS];
There is no need to split the interface_opts into a new data structure.
See my fixes patch.
next prev parent reply other threads:[~2023-01-04 16:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:24 [PATCH 1/6] app/dumpcap: add additional dump info Ben Magistro
2023-01-02 16:24 ` [PATCH 2/6] app/dumpcap: fix storing port identifier Ben Magistro
2023-01-02 16:58 ` Stephen Hemminger
2023-01-04 3:04 ` Stephen Hemminger
2023-01-02 16:24 ` [PATCH 3/6] app/dumpcap: fix preserving promiscuous mode Ben Magistro
2023-01-02 16:58 ` Stephen Hemminger
2023-01-04 3:04 ` Stephen Hemminger
2023-01-02 16:24 ` [PATCH 4/6] app/dumpcap: fix capturing on multiple interfaces Ben Magistro
2023-01-04 3:01 ` Stephen Hemminger
2023-01-02 16:24 ` [PATCH 5/6] app/dumpcap: improve per interface arg parsing Ben Magistro
2023-01-04 3:04 ` Stephen Hemminger [this message]
2023-01-02 16:24 ` [PATCH 6/6] app/dumpcap: refactor add all and default Ben Magistro
2023-01-02 16:57 ` [PATCH 1/6] app/dumpcap: add additional dump info Stephen Hemminger
2023-01-02 17:01 ` [RFT] dumpcap: fix multiple interface and promiscious handling Stephen Hemminger
2023-01-04 2:58 ` [PATCH 1/6] app/dumpcap: add additional dump info Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 0/6] dumpcap support multiple interfaces Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 1/6] app/dumpcap: fix storing port identifier Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 2/6] app/dumpcap: remove unused variable Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 3/6] app/dumpcap: check for invalid interface name Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 4/6] app/dumpcap: support multiple interfaces Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 5/6] pcapng: require per-interface information Stephen Hemminger
2023-01-04 3:38 ` [PATCH v2 6/6] app/dumpcap: support interface name and description Stephen Hemminger
2023-02-06 11:18 ` [PATCH v2 0/6] dumpcap support multiple interfaces Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103190418.22ed1fce@hermes.local \
--to=stephen@networkplumber.org \
--cc=ben.magistro@trinitycyber.com \
--cc=dev@dpdk.org \
--cc=koncept1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).