DPDK patches and discussions
 help / color / mirror / Atom feed

From: Huisong Li <lihuisong@huawei.com>
To: <dev@dpdk.org>
Cc: <bruce.richardson@intel.com>, <mb@smartsharesystems.com>,
	<andrew.rybchenko@oktetlabs.ru>, <huangdaode@huawei.com>,
	<liudongdong3@huawei.com>, <fengchengwen@huawei.com>,
	<lihuisong@huawei.com>
Subject: [PATCH v2 1/2] usertools: use argparse module to get input parameter
Date: Tue, 10 Jan 2023 15:31:45 +0800	[thread overview]
Message-ID: <20230110073146.8221-2-lihuisong@huawei.com> (raw)
In-Reply-To: <20230110073146.8221-1-lihuisong@huawei.com>

The telemetry client script uses argparse module to get input parameter.
argparse uses an optional positional arguments for local socket path to
keep backward compatibility.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 usertools/dpdk-telemetry-client.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index df41d04fbe..144a8fb5e0 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -6,6 +6,7 @@
 import os
 import sys
 import time
+import argparse
 
 BUFFER_SIZE = 200000
 
@@ -115,13 +116,12 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
 if __name__ == "__main__":
 
     sleep_time = 1
-    file_path = ""
-    if len(sys.argv) == 2:
-        file_path = sys.argv[1]
-    else:
-        print("Warning - No filepath passed, using default (" + DEFAULT_FP + ").")
-        file_path = DEFAULT_FP
+    parser = argparse.ArgumentParser()
+    parser.add_argument('sock_path', nargs='?', default=DEFAULT_FP,
+                        help='Provide socket file path connected by legacy client')
+    args = parser.parse_args()
+
     client = Client()
-    client.getFilepath(file_path)
+    client.getFilepath(args.sock_path)
     client.register()
     client.interactiveMenu(sleep_time)
-- 
2.22.0

next prev parent reply	other threads:[~2023-01-10  7:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  6:55 [PATCH 0/2] usertools: use argparse module to get input and add an argment Huisong Li
2023-01-09  6:55 ` [PATCH 1/2] usertools: use argparse module to get input parameter Huisong Li
2023-01-09  9:14   ` Bruce Richardson
2023-01-09 12:26     ` lihuisong (C)
2023-01-09 14:32       ` Bruce Richardson
2023-01-10  6:24         ` lihuisong (C)
2023-01-09  6:55 ` [PATCH 2/2] usertools: add an argment for file prefix Huisong Li
2023-01-09  9:16   ` Bruce Richardson
2023-01-09 17:07 ` [PATCH] usertools: fix python warnings Stephen Hemminger
2023-02-06  7:47   ` Thomas Monjalon
2023-01-10  7:31 ` [PATCH v2 0/2] usertools: usertools: use argparse to get input and add an argument Huisong Li
2023-01-10  7:31   ` Huisong Li [this message]
2023-01-10  9:12     ` [PATCH v2 1/2] usertools: use argparse module to get input parameter Bruce Richardson
2023-01-10  7:31   ` [PATCH v2 2/2] usertools: add an argument for file prefix Huisong Li
2023-02-06  8:30   ` [PATCH v2 0/2] usertools: usertools: use argparse to get input and add an argument Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110073146.8221-2-lihuisong@huawei.com \
    --to=lihuisong@huawei.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=huangdaode@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).