From: Ke Zhang <ke1x.zhang@intel.com>
To: qi.z.zhang@intel.com, yuying.zhang@intel.com, dev@dpdk.org
Cc: "ke1x.zhang" <ke1x.zhang@intel.com>
Subject: [PATCH v3] net/ice: add devargs for disabling default mac
Date: Thu, 12 Jan 2023 15:55:38 +0800 [thread overview]
Message-ID: <20230112075538.206709-1-ke1x.zhang@intel.com> (raw)
In-Reply-To: <20221221035804.1241780-1-ke1x.zhang@intel.com>
From: "ke1x.zhang" <ke1x.zhang@intel.com>
Add the feature that support to disable default mac which
will be used by ice driver when setting dpdk_devargs config
field.
Default mac is not disabled in default, user can
choose to disable the default mac
by setting ``devargs`` parameter ``default-mac-disable``,
for example::
-a 80:00.0,default-mac-disable=1
Signed-off-by: ke1x.zhang <ke1x.zhang@intel.com>
---
doc/guides/nics/ice.rst | 11 +++++++++++
drivers/net/ice/ice_ethdev.c | 21 ++++++++++++++++++---
drivers/net/ice/ice_ethdev.h | 1 +
3 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index ce075e067c..860ed1430d 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -105,6 +105,17 @@ Runtime Config Options
-a 80:00.0,pipeline-mode-support=1
+- ``Default Mac Disable`` (default ``0``)
+
+ Add the feature that support to disable default mac which will be used by ice driver
+ when setting dpdk_devargs config field.
+
+ Default mac is not disabled in default, user can choose to disable the default mac
+ by setting ``devargs`` parameter ``default-mac-disable``,
+ for example::
+
+ -a 80:00.0,default-mac-disable=1
+
- ``Protocol extraction for per queue``
Configure the RX queues to do protocol extraction into mbuf for protocol
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 0bc739daf0..0d011bbffa 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -28,6 +28,7 @@
/* devargs */
#define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support"
#define ICE_PIPELINE_MODE_SUPPORT_ARG "pipeline-mode-support"
+#define ICE_DEFAULT_MAC_DISABLE "default-mac-disable"
#define ICE_PROTO_XTR_ARG "proto_xtr"
#define ICE_FIELD_OFFS_ARG "field_offs"
#define ICE_FIELD_NAME_ARG "field_name"
@@ -49,6 +50,7 @@ static const char * const ice_valid_args[] = {
ICE_HW_DEBUG_MASK_ARG,
ICE_ONE_PPS_OUT_ARG,
ICE_RX_LOW_LATENCY_ARG,
+ ICE_DEFAULT_MAC_DISABLE,
NULL
};
@@ -916,6 +918,7 @@ static int
ice_init_mac_address(struct rte_eth_dev *dev)
{
struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+ struct ice_adapter *ad = (struct ice_adapter *)hw->back;
if (!rte_is_unicast_ether_addr
((struct rte_ether_addr *)hw->port_info[0].mac.lan_addr)) {
@@ -935,9 +938,9 @@ ice_init_mac_address(struct rte_eth_dev *dev)
return -ENOMEM;
}
/* store it to dev data */
- rte_ether_addr_copy(
- (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr,
- &dev->data->mac_addrs[0]);
+ if (ad->devargs.default_mac_disable != 1)
+ rte_ether_addr_copy((struct rte_ether_addr *)hw->port_info[0].mac.perm_addr,
+ &dev->data->mac_addrs[0]);
return 0;
}
@@ -962,8 +965,14 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
struct ice_mac_filter *f;
struct LIST_HEAD_TYPE list_head;
struct ice_hw *hw = ICE_VSI_TO_HW(vsi);
+ struct ice_adapter *ad = (struct ice_adapter *)hw->back;
int ret = 0;
+ if (ad->devargs.default_mac_disable == 1 && rte_is_same_ether_addr(mac_addr,
+ (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr)) {
+ PMD_DRV_LOG(ERR, "This Default MAC filter is disabled.");
+ return 0;
+ }
/* If it's added and configured, return */
f = ice_find_mac_filter(vsi, mac_addr);
if (f) {
@@ -2075,6 +2084,11 @@ static int ice_parse_devargs(struct rte_eth_dev *dev)
if (ret)
goto bail;
+ ret = rte_kvargs_process(kvlist, ICE_DEFAULT_MAC_DISABLE,
+ &parse_bool, &ad->devargs.default_mac_disable);
+ if (ret)
+ goto bail;
+
ret = rte_kvargs_process(kvlist, ICE_HW_DEBUG_MASK_ARG,
&parse_u64, &ad->hw.debug_mask);
if (ret)
@@ -6050,6 +6064,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_ice,
ICE_PROTO_XTR_ARG "=[queue:]<vlan|ipv4|ipv6|ipv6_flow|tcp|ip_offset>"
ICE_SAFE_MODE_SUPPORT_ARG "=<0|1>"
ICE_PIPELINE_MODE_SUPPORT_ARG "=<0|1>"
+ ICE_DEFAULT_MAC_DISABLE "=<0|1>"
ICE_RX_LOW_LATENCY_ARG "=<0|1>");
RTE_LOG_REGISTER_SUFFIX(ice_logtype_init, init, NOTICE);
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index c8311be179..9140f3af79 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -563,6 +563,7 @@ struct ice_devargs {
int safe_mode_support;
uint8_t proto_xtr_dflt;
int pipe_mode_support;
+ uint8_t default_mac_disable;
uint8_t proto_xtr[ICE_MAX_QUEUE_NUM];
uint8_t pin_idx;
uint8_t pps_out_ena;
--
2.34.1
next prev parent reply other threads:[~2023-01-12 8:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 2:51 [PATCH] net/ice: add devargs for disabling mac filter Ke Zhang
2022-12-13 2:03 ` Zhang, Qi Z
2022-12-13 3:51 ` Stephen Hemminger
2022-12-13 5:43 ` Zhang, Ke1X
2022-12-13 5:44 ` Zhang, Ke1X
2022-12-17 15:22 ` Zhang, Ke1X
2022-12-17 17:20 ` Stephen Hemminger
2022-12-21 3:58 ` [PATCH v2] " Ke Zhang
2022-12-26 6:14 ` Zhang, Qi Z
2022-12-28 8:55 ` Zhang, Ke1X
2023-01-12 7:55 ` Ke Zhang [this message]
2023-01-12 16:32 ` [PATCH v3] net/ice: add devargs for disabling default mac Stephen Hemminger
2023-01-16 13:38 ` Zhang, Ke1X
2023-02-01 8:22 ` Zhang, Qi Z
2023-02-03 2:02 ` [PATCH v4] " Ke Zhang
2023-02-13 1:48 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112075538.206709-1-ke1x.zhang@intel.com \
--to=ke1x.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).